linux-kernel - Re: [PATCH v3 3/9] gpu: host1x: Add context device management code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Feb 2022 13:35:32 +0200
From:   Mikko Perttunen <cyndis@...si.fi>
To:     Dmitry Osipenko <digetx@...il.com>,
        Mikko Perttunen <mperttunen@...dia.com>,
        thierry.reding@...il.com, jonathanh@...dia.com, joro@...tes.org,
        will@...nel.org, robh+dt@...nel.org, robin.murphy@....com
Cc:     linux-tegra@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 3/9] gpu: host1x: Add context device management code

On 2/19/22 19:48, Dmitry Osipenko wrote:
> 18.02.2022 14:39, Mikko Perttunen пишет:
> ...
>> +/*
>> + * Due to an issue with T194 NVENC, only 38 bits can be used.
>> + * Anyway, 256GiB of IOVA ought to be enough for anyone.
>> + */
>> +static dma_addr_t context_device_dma_mask = DMA_BIT_MASK(38);
> 
> s/dma_addr_t/u64/ ? Apparently you should get compilation warning on ARM32.
> 
> https://elixir.bootlin.com/linux/v5.17-rc4/source/include/linux/device.h#L524 >
>> +int host1x_context_list_init(struct host1x *host1x)
>> +{
>> +	struct host1x_context_list *cdl = &host1x->context_list;
>> +	struct host1x_context *ctx;
>> +	struct device_node *node;
>> +	int index;
> 
> Nitpick: unsigned int
> 
> ...
>> +del_devices:
>> +	while (--index >= 0)
> 
> Nitpick: while (index--)
> 
> ... >> +void host1x_context_list_free(struct host1x_context_list *cdl)
>> +{
>> +	int i;
> 
> Nitpick: unsigned int
> 

Thanks, fixed all.

Mikko