linux-kernel - Re: [PATCH v2 03/10] random: remove whitespace and reorder includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YhMWi+zuIH9XPvmS@sol.localdomain>
Date:   Sun, 20 Feb 2022 20:35:23 -0800
From:   Eric Biggers <ebiggers@...nel.org>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     linux-kernel@...r.kernel.org, linux@...inikbrodowski.net
Subject: Re: [PATCH v2 03/10] random: remove whitespace and reorder includes

On Sat, Feb 12, 2022 at 01:23:11PM +0100, Jason A. Donenfeld wrote:
> This is purely cosmetic. Future work involves figuring out which of
> these headers we need and which we don't.
> 
> Cc: Dominik Brodowski <linux@...inikbrodowski.net>
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> ---
>  drivers/char/random.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index 436b146b33be..7bb18422705a 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -193,11 +193,10 @@
>  #include <linux/syscalls.h>
>  #include <linux/completion.h>
>  #include <linux/uuid.h>
> +#include <linux/uaccess.h>
>  #include <crypto/chacha.h>
>  #include <crypto/blake2s.h>
> -
>  #include <asm/processor.h>
> -#include <linux/uaccess.h>
>  #include <asm/irq.h>
>  #include <asm/irq_regs.h>
>  #include <asm/io.h>
> -- 

Reviewed-by: Eric Biggers <ebiggers@...gle.com>

- Eric