linux-kernel - Re: [PATCH v4 01/15] crypto: kpp - provide support for KPP template instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Feb 2022 14:18:36 +0100
From:   Hannes Reinecke <hare@...e.de>
To:     Nicolai Stange <nstange@...e.de>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Stephan Müller <smueller@...onox.de>,
        Torsten Duwe <duwe@...e.de>,
        David Howells <dhowells@...hat.com>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        keyrings@...r.kernel.org
Subject: Re: [PATCH v4 01/15] crypto: kpp - provide support for KPP template
 instances

On 2/21/22 13:10, Nicolai Stange wrote:
> The upcoming support for the RFC 7919 ffdhe group parameters will be
> made available in the form of templates like "ffdhe2048(dh)",
> "ffdhe3072(dh)" and so on. Template instantiations thereof would wrap the
> inner "dh" kpp_alg and also provide kpp_alg services to the outside again.
> Furthermore, it might be perhaps be desirable to provide KDF templates in
> the future, which would similarly wrap an inner kpp_alg and present
> themselves to the outside as another kpp_alg, transforming the shared
> secret on its way out.
> 
> Introduce the bits needed for supporting KPP template instances. Everything
> related to inner kpp_alg spawns potentially being held by such template
> instances will be deferred to a subsequent patch in order to facilitate
> review.
> 
> Define struct struct kpp_instance in close analogy to the already existing
> skcipher_instance, shash_instance and alike, but wrapping a struct kpp_alg.
> Implement the new kpp_register_instance() template instance registration
> primitive. Provide some helper functions for
> - going back and forth between a generic struct crypto_instance and the new
>    struct kpp_instance,
> - obtaining the instantiating kpp_instance from a crypto_kpp transform and
> - for accessing a given kpp_instance's implementation specific context
>    data.
> 
> Annotate everything with proper kernel-doc comments, even though
> include/crypto/internal/kpp.h is not considered for the generated docs.
> 
> Signed-off-by: Nicolai Stange <nstange@...e.de>
> ---
>   crypto/kpp.c                  | 20 +++++++++
>   include/crypto/internal/kpp.h | 83 +++++++++++++++++++++++++++++++++++
>   2 files changed, 103 insertions(+)
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@...e.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer