linux-kernel - Re: [PATCH v3 3/9] gpu: host1x: Add context device management code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a1387e5-b68f-db90-9ab5-0b8606ca8841@kapsi.fi>
Date:   Mon, 21 Feb 2022 13:37:54 +0200
From:   Mikko Perttunen <cyndis@...si.fi>
To:     Dmitry Osipenko <digetx@...il.com>,
        Mikko Perttunen <mperttunen@...dia.com>,
        thierry.reding@...il.com, jonathanh@...dia.com, joro@...tes.org,
        will@...nel.org, robh+dt@...nel.org, robin.murphy@....com
Cc:     linux-tegra@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 3/9] gpu: host1x: Add context device management code

On 2/19/22 19:52, Dmitry Osipenko wrote:
> 18.02.2022 14:39, Mikko Perttunen пишет:
>> +	for (index = 0; index < cdl->len; index++) {
>> +		struct iommu_fwspec *fwspec;
>> +
>> +		ctx = &cdl->devs[index];
>> +
>> +		ctx->host = host1x;
>> +
>> +		device_initialize(&ctx->dev);
>> +
>> +		ctx->dev.dma_mask = &context_device_dma_mask;
>> +		ctx->dev.coherent_dma_mask = context_device_dma_mask;
>> +		dev_set_name(&ctx->dev, "host1x-ctx.%d", index);
>> +		ctx->dev.bus = &host1x_context_device_bus_type;
> 
> host1x_context_device_bus_type will be an undefined symbol if
> CONFIG_TEGRA_HOST1X_CONTEXT_BUS=n? Please compile and test all combinations.

But this file is only built if CONFIG_HOST1X, which selects 
CONFIG_TEGRA_HOST1X_CONTEXT_BUS?

Mikko