linux-kernel - Re: [PATCH v4 10/15] crypto: testmgr - add keygen tests for ffdheXYZ(dh) templates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <efa504c2-f3a6-fab4-60aa-7d9e0e90b4c4@suse.de>
Date:   Mon, 21 Feb 2022 15:18:14 +0100
From:   Hannes Reinecke <hare@...e.de>
To:     Nicolai Stange <nstange@...e.de>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Stephan Müller <smueller@...onox.de>,
        Torsten Duwe <duwe@...e.de>,
        David Howells <dhowells@...hat.com>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        keyrings@...r.kernel.org
Subject: Re: [PATCH v4 10/15] crypto: testmgr - add keygen tests for
 ffdheXYZ(dh) templates

On 2/21/22 13:10, Nicolai Stange wrote:
> Now that the ffdheXYZ(dh) templates support ephemeral key generation, add
> ->keygen = 1 TVs for each of them to the testmgr.c.
> 
> In order to facilitate string merging by the compiler, set party B's secret
> and public keys to the ones specified for party A in the respective
> existing known answer test. With GCC 7.5 on x86_64, this leads to an
> increase of testmgr.o size by less than half a kB.
> 
> Signed-off-by: Nicolai Stange <nstange@...e.de>
> ---
>   crypto/testmgr.h | 578 ++++++++++++++++++++++++++++++++++++++++++++++-
>   1 file changed, 568 insertions(+), 10 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@...e.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer