linux-kernel - Re: [PATCH] random: pull add_hwgenerator_randomness() declaration into random.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YhMot77If2Txl+cL@sol.localdomain>
Date:   Sun, 20 Feb 2022 21:52:55 -0800
From:   Eric Biggers <ebiggers@...nel.org>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     linux-kernel@...r.kernel.org, linux@...inikbrodowski.net,
        herbert@...dor.apana.org.au, linux-crypto@...r.kernel.org,
        Matt Mackall <mpm@...enic.com>, Kalle Valo <kvalo@...nel.org>,
        ath9k-devel@....qualcomm.com, Theodore Ts'o <tytso@....edu>
Subject: Re: [PATCH] random: pull add_hwgenerator_randomness() declaration
 into random.h

On Sun, Feb 13, 2022 at 04:25:22PM +0100, Jason A. Donenfeld wrote:
> add_hwgenerator_randomness() is a function implemented and documented
> inside of random.c. It is the way that hardware RNGs push data into it.
> Therefore, it should be declared in random.h. Otherwise sparse complains
> with:
> 
> random.c:1137:6: warning: symbol 'add_hwgenerator_randomness' was not declared. Should it be static?
> 
> The alternative would be to include hw_random.h into random.c, but that
> wouldn't really be good for anything except slowing down compile time.
> 
> Cc: Dominik Brodowski <linux@...inikbrodowski.net>
> Cc: Matt Mackall <mpm@...enic.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: linux-crypto@...r.kernel.org
> Cc: Kalle Valo <kvalo@...nel.org>
> Cc: ath9k-devel@....qualcomm.com
> Cc: Theodore Ts'o <tytso@....edu>
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> ---
>  drivers/char/hw_random/core.c        | 1 +
>  drivers/net/wireless/ath/ath9k/rng.c | 1 +
>  include/linux/hw_random.h            | 2 --
>  include/linux/random.h               | 2 ++
>  4 files changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Eric Biggers <ebiggers@...gle.com>

- Eric