linux-kernel - Re: [PATCH] drm/amdgpu: fix printk format for size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84e354ec-cfbf-a23f-ddd5-417d6f029873@amd.com>
Date:   Mon, 21 Feb 2022 14:57:22 -0500
From:   Luben Tuikov <luben.tuikov@....com>
To:     trix@...hat.com, alexander.deucher@....com,
        christian.koenig@....com, Xinhui.Pan@....com, airlied@...ux.ie,
        daniel@...ll.ch, guchun.chen@....com, Prike.Liang@....com,
        Hawking.Zhang@....com
Cc:     dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: fix printk format for size_t variable

Hi Tom,

This was already fixed with this patch, and LKML was CC-ed. See the CC tags in the patch below,

commit 4f7d7cda90cbd7
Author: Luben Tuikov <luben.tuikov@....com>
Date:   Wed Feb 16 16:47:32 2022 -0500

    drm/amdgpu: Fix ARM compilation warning
    
    Fix this ARM warning:
    
    drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:664:35: warning: format '%ld'
    expects argument of type 'long int', but argument 4 has type 'size_t' {aka
    'unsigned int'} [-Wformat=]
    
    Cc: Alex Deucher <Alexander.Deucher@....com>
    Cc: kbuild-all@...ts.01.org
    Cc: linux-kernel@...r.kernel.org
    Reported-by: kernel test robot <lkp@...el.com>
    Fixes: 7e60fbfbdc10a0 ("drm/amdgpu: Show IP discovery in sysfs")
    Signed-off-by: Luben Tuikov <luben.tuikov@....com>
    Acked-by: Alex Deucher <Alexander.Deucher@....com>

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index 2506bcf36c870c..6c7ec058125e1d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
@@ -668,7 +668,7 @@ static int amdgpu_discovery_sysfs_ips(struct amdgpu_device *adev,
                            le16_to_cpu(ip->hw_id) != ii)
                                goto next_ip;
 
-                       DRM_DEBUG("match:%d @ ip_offset:%ld", ii, ip_offset);
+                       DRM_DEBUG("match:%d @ ip_offset:%zu", ii, ip_offset);
 
                        /* We have a hw_id match; register the hw
                         * block if not yet registered.

Regards,
Luben

On 2022-02-21 12:37, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> On mips64 allyesconfig, there is this build break
> amdgpu_discovery.c:671:35: error: format '%ld' expects
>   argument of type 'long int', but argument 4 has
>   type 'size_t' {aka 'unsigned int'}
>   DRM_DEBUG("match:%d @ ip_offset:%ld", ii, ip_offset);
> 
> For size_t, use %zu.
> 
> Fixes: a6c40b178092 ("drm/amdgpu: Show IP discovery in sysfs")
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> index 7c7e28fd912e..58238f67b1d3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> @@ -668,7 +668,7 @@ static int amdgpu_discovery_sysfs_ips(struct amdgpu_device *adev,
>  			    le16_to_cpu(ip->hw_id) != ii)
>  				goto next_ip;
>  
> -			DRM_DEBUG("match:%d @ ip_offset:%ld", ii, ip_offset);
> +			DRM_DEBUG("match:%d @ ip_offset:%zu", ii, ip_offset);
>  
>  			/* We have a hw_id match; register the hw
>  			 * block if not yet registered.

Regards,
-- 
Luben