| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Feb 2022 00:14:05 +0100
From: Jarkko Sakkinen <jarkko.sakkinen@....fi>
To: trix@...hat.com
Cc: dhowells@...hat.com, herbert@...dor.apana.org.au,
davem@...emloft.net, dan.j.williams@...el.com, song@...nel.org,
xni@...hat.com, keyrings@...r.kernel.org,
linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: cleanup comments
On Mon, Feb 21, 2022 at 02:31:18PM -0800, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
>
> For spdx
> /* */ for *.h, // for *.c
> Space before spdx tag
>
> Replacements
> paramenters to parameters
> aymmetric to asymmetric
> sigature to signature
> boudary to boundary
> compliled to compiled
> eninges to engines
> explicity to explicitly
>
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
> crypto/asymmetric_keys/signature.c | 2 +-
> crypto/asymmetric_keys/x509_parser.h | 2 +-
> crypto/async_tx/async_xor.c | 8 ++++----
> crypto/async_tx/raid6test.c | 4 ++--
> crypto/cfb.c | 2 +-
> crypto/dh.c | 2 +-
> crypto/sm2.c | 2 +-
> 7 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/crypto/asymmetric_keys/signature.c b/crypto/asymmetric_keys/signature.c
> index 4aff3eebec17..2deff81f8af5 100644
> --- a/crypto/asymmetric_keys/signature.c
> +++ b/crypto/asymmetric_keys/signature.c
> @@ -35,7 +35,7 @@ void public_key_signature_free(struct public_key_signature *sig)
> EXPORT_SYMBOL_GPL(public_key_signature_free);
>
> /**
> - * query_asymmetric_key - Get information about an aymmetric key.
> + * query_asymmetric_key - Get information about an asymmetric key.
> * @params: Various parameters.
> * @info: Where to put the information.
> */
> diff --git a/crypto/asymmetric_keys/x509_parser.h b/crypto/asymmetric_keys/x509_parser.h
> index c233f136fb35..668f5c9f0b54 100644
> --- a/crypto/asymmetric_keys/x509_parser.h
> +++ b/crypto/asymmetric_keys/x509_parser.h
> @@ -22,7 +22,7 @@ struct x509_certificate {
> time64_t valid_to;
> const void *tbs; /* Signed data */
> unsigned tbs_size; /* Size of signed data */
> - unsigned raw_sig_size; /* Size of sigature */
> + unsigned raw_sig_size; /* Size of signature */
> const void *raw_sig; /* Signature data */
> const void *raw_serial; /* Raw serial number in ASN.1 */
> unsigned raw_serial_size;
> diff --git a/crypto/async_tx/async_xor.c b/crypto/async_tx/async_xor.c
> index d8a91521144e..1a3855284091 100644
> --- a/crypto/async_tx/async_xor.c
> +++ b/crypto/async_tx/async_xor.c
> @@ -170,8 +170,8 @@ dma_xor_aligned_offsets(struct dma_device *device, unsigned int offset,
> *
> * xor_blocks always uses the dest as a source so the
> * ASYNC_TX_XOR_ZERO_DST flag must be set to not include dest data in
> - * the calculation. The assumption with dma eninges is that they only
> - * use the destination buffer as a source when it is explicity specified
> + * the calculation. The assumption with dma engines is that they only
> + * use the destination buffer as a source when it is explicitly specified
> * in the source list.
> *
> * src_list note: if the dest is also a source it must be at index zero.
> @@ -261,8 +261,8 @@ EXPORT_SYMBOL_GPL(async_xor_offs);
> *
> * xor_blocks always uses the dest as a source so the
> * ASYNC_TX_XOR_ZERO_DST flag must be set to not include dest data in
> - * the calculation. The assumption with dma eninges is that they only
> - * use the destination buffer as a source when it is explicity specified
> + * the calculation. The assumption with dma engines is that they only
> + * use the destination buffer as a source when it is explicitly specified
> * in the source list.
> *
> * src_list note: if the dest is also a source it must be at index zero.
> diff --git a/crypto/async_tx/raid6test.c b/crypto/async_tx/raid6test.c
> index 66db82e5a3b1..c9d218e53bcb 100644
> --- a/crypto/async_tx/raid6test.c
> +++ b/crypto/async_tx/raid6test.c
> @@ -217,7 +217,7 @@ static int raid6_test(void)
> err += test(12, &tests);
> }
>
> - /* the 24 disk case is special for ioatdma as it is the boudary point
> + /* the 24 disk case is special for ioatdma as it is the boundary point
> * at which it needs to switch from 8-source ops to 16-source
> * ops for continuation (assumes DMA_HAS_PQ_CONTINUE is not set)
> */
> @@ -241,7 +241,7 @@ static void raid6_test_exit(void)
> }
>
> /* when compiled-in wait for drivers to load first (assumes dma drivers
> - * are also compliled-in)
> + * are also compiled-in)
> */
> late_initcall(raid6_test);
> module_exit(raid6_test_exit);
> diff --git a/crypto/cfb.c b/crypto/cfb.c
> index 0d664dfb47bc..5c36b7b65e2a 100644
> --- a/crypto/cfb.c
> +++ b/crypto/cfb.c
> @@ -1,4 +1,4 @@
> -//SPDX-License-Identifier: GPL-2.0
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * CFB: Cipher FeedBack mode
> *
> diff --git a/crypto/dh.c b/crypto/dh.c
> index 27e62a2a8027..be3138636726 100644
> --- a/crypto/dh.c
> +++ b/crypto/dh.c
> @@ -104,7 +104,7 @@ static int dh_set_secret(struct crypto_kpp *tfm, const void *buf,
> /*
> * SP800-56A public key verification:
> *
> - * * If Q is provided as part of the domain paramenters, a full validation
> + * * If Q is provided as part of the domain parameters, a full validation
> * according to SP800-56A section 5.6.2.3.1 is performed.
> *
> * * If Q is not provided, a partial validation according to SP800-56A section
> diff --git a/crypto/sm2.c b/crypto/sm2.c
> index ae3f77a66070..f3e1592965c0 100644
> --- a/crypto/sm2.c
> +++ b/crypto/sm2.c
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> * SM2 asymmetric public-key algorithm
> * as specified by OSCCA GM/T 0003.1-2012 -- 0003.5-2012 SM2 and
> --
> 2.26.3
>
Acked-by: Jarkko Sakkinen <jarkko@...nel.org>
BR, Jarkko
Powered by blists - more mailing lists