linux-kernel - Re: [PATCH v2] perf test: Skip Sigtrap test for arm+aarch64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <447ebda7-eaff-f765-d6ec-66ad0fc957a0@linux.ibm.com>
Date:   Mon, 21 Feb 2022 15:22:32 +0530
From:   kajoljain <kjain@...ux.ibm.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Leo Yan <leo.yan@...aro.org>
Cc:     John Garry <john.garry@...wei.com>, peterz@...radead.org,
        mingo@...hat.com, mark.rutland@....com, jolsa@...nel.org,
        namhyung@...nel.org, elver@...gle.com, dvyukov@...gle.com,
        will@...nel.org, linux-perf-users@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux@...linux.org.uk, tmricht@...ux.ibm.com, irogers@...gle.com
Subject: Re: [PATCH v2] perf test: Skip Sigtrap test for arm+aarch64



On 2/18/22 6:26 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Feb 18, 2022 at 06:46:11PM +0800, Leo Yan escreveu:
>> On Fri, Feb 18, 2022 at 05:33:33PM +0800, John Garry wrote:
>>> Skip the Sigtrap test for arm + arm64, same as was done for s390 in
>>> commit a840974e96fd ("perf test: Test 73 Sig_trap fails on s390"). For
>>> this, reuse BP_SIGNAL_IS_SUPPORTED - meaning that the arch can use BP to
>>> generate signals - instead of BP_ACCOUNT_IS_SUPPORTED, which is
>>> appropriate.
>>>
>>> As described by Will at [0], in the test we get stuck in a loop of handling
>>> the HW breakpoint exception and never making progress. GDB handles this
>>> by stepping over the faulting instruction, but with perf the kernel is
>>> expected to handle the step (which it doesn't for arm).
>>>
>>> Dmitry made an attempt to get this work, also mentioned in the same thread
>>> as [0], which was appreciated. But the best thing to do is skip the test
>>> for now.
>>>
>>> [0] https://lore.kernel.org/linux-perf-users/20220118124343.GC98966@leoy-ThinkPad-X240s/T/#m13b06c39d2a5100d340f009435df6f4d8ee57b5a
>>>
>>> Fixes: Fixes: 5504f67944484 ("perf test sigtrap: Add basic stress test for sigtrap handling")
>>> Signed-off-by: John Garry <john.garry@...wei.com>
>>
>> I tested this patch on my Juno board:
>>
>> root@...o:# ./perf test 73
>>  73: Sigtrap                                                         : Skip
>>
>> Tested-by: Leo Yan <leo.yan@...aro.org>

Sorry for late update.

Patch looks good to me. I tested it on powerpc.

Tested-by: Kajol Jain<kjain@...ux.ibm.com>

Thanks,
Kajol Jain
> 
> Thanks, applied.
> 
> - Arnaldo
>