linux-kernel - Re: [PATCH 01/11] kernel/parisc: move soft-power sysctl to its own file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 21 Feb 2022 13:26:49 +0800
From:   kernel test robot <lkp@...el.com>
To:     tangmeng <tangmeng@...ontech.com>,
        James.Bottomley@...senPartnership.com, deller@....de,
        mcgrof@...nel.org, keescook@...omium.org, yzaikin@...gle.com
Cc:     kbuild-all@...ts.01.org, linux-parisc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        nizhen@...ontech.com, zhanglianjie@...ontech.com,
        nixiaoming@...wei.com, tangmeng <tangmeng@...ontech.com>
Subject: Re: [PATCH 01/11] kernel/parisc: move soft-power sysctl to its own
 file

Hi tangmeng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on hnaz-mm/master]
[also build test ERROR on deller-parisc/for-next rostedt-trace/for-next linus/master v5.17-rc5 next-20220217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/tangmeng/kernel-parisc-move-soft-power-sysctl-to-its-own-file/20220220-174553
base:   https://github.com/hnaz/linux-mm master
config: parisc-randconfig-s031-20220220 (https://download.01.org/0day-ci/archive/20220221/202202211342.EcgL15uq-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/fc2d0c0a37a34fd9c89e5519f2aea93de690c2ce
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review tangmeng/kernel-parisc-move-soft-power-sysctl-to-its-own-file/20220220-174553
        git checkout fc2d0c0a37a34fd9c89e5519f2aea93de690c2ce
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=parisc SHELL=/bin/bash drivers/parisc/ mm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/parisc/power.c:196:12: error: static declaration of 'pwrsw_enabled' follows non-static declaration
     196 | static int pwrsw_enabled;
         |            ^~~~~~~~~~~~~
   drivers/parisc/power.c:112:5: note: previous definition of 'pwrsw_enabled' with type 'int'
     112 | int pwrsw_enabled __read_mostly = 1;
         |     ^~~~~~~~~~~~~


vim +/pwrsw_enabled +196 drivers/parisc/power.c

   195	
 > 196	static int pwrsw_enabled;
   197	#ifdef CONFIG_SYSCTL
   198	static struct ctl_table kern_parisc_power_table[] = {
   199		{
   200			.procname       = "soft-power",
   201			.data           = &pwrsw_enabled,
   202			.maxlen         = sizeof(int),
   203			.mode           = 0644,
   204			.proc_handler   = proc_dointvec,
   205		},
   206		{ }
   207	};
   208	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org