linux-kernel - Re: [PATCH 2/2] Documentation/vm/page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f27d2965-bd4d-bad3-4137-09c7f4214bd9@linuxfoundation.org>
Date:   Tue, 22 Feb 2022 11:59:01 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Yixuan Cao <caoyixuan2019@...il.szu.edu.cn>, corbet@....net
Cc:     akpm@...ux-foundation.org, sfr@...b.auug.org.au,
        hanshenghong2019@...il.szu.edu.cn, vbabka@...e.cz,
        georgi.djakov@...aro.org, weizhenliang@...wei.com,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 2/2] Documentation/vm/page_owner.rst: fix a phrase

On 2/20/22 1:29 AM, Yixuan Cao wrote:
> I think that using "by default" will be better.
> 
> Signed-off-by: Yixuan Cao <caoyixuan2019@...il.szu.edu.cn>

While you are at it could you fix others as well:

> ---
>   Documentation/vm/page_owner.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/vm/page_owner.rst b/Documentation/vm/page_owner.rst
> index 2b54e82b9fe1..5ac1c12fcfc2 100644
> --- a/Documentation/vm/page_owner.rst
> +++ b/Documentation/vm/page_owner.rst
> @@ -26,7 +26,7 @@ fragmentation statistics can be obtained through gfp flag information of
>   each page. It is already implemented and activated if page owner is
>   enabled. Other usages are more than welcome.
>   
> -page owner is disabled in default. So, if you'd like to use it, you need
> +page owner is disabled by default. So, if you'd like to use it, you need
>   to add "page_owner=on" into your boot cmdline. If the kernel is built

page owner is disabled by default. So, if you'd like to use it, you need
to add "page_owner=on" to your boot cmdline.

>   with page owner and page owner is disabled in runtime due to no enabling

with page owner and page owner is disabled in runtime due to not enabling

>   boot option, runtime overhead is marginal. If disabled in runtime, it
> 

With these fixed:

Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah