lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Feb 2022 15:28:03 -0500 From: NĂcolas F. R. A. Prado <nfraprado@...labora.com> To: Allen-KH Cheng <allen-kh.cheng@...iatek.com> Cc: Matthias Brugger <matthias.bgg@...il.com>, Rob Herring <robh+dt@...nel.org>, --to=Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>, Project_Global_Chrome_Upstream_Group@...iatek.com, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org, Chen-Yu Tsai <wenst@...omium.org>, Ryder Lee <ryder.lee@...nel.org> Subject: Re: [PATCH v2 07/23] arm64: dts: mt8192: Add xhci node On Fri, Feb 18, 2022 at 05:16:17PM +0800, Allen-KH Cheng wrote: > Add xhci node for mt8192 SoC. > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@...iatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 25 ++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index ce18d692175f..08c7c1c772f5 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > @@ -10,6 +10,7 @@ > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/pinctrl/mt8192-pinfunc.h> > +#include <dt-bindings/phy/phy.h> > #include <dt-bindings/power/mt8192-power.h> > > / { > @@ -718,6 +719,30 @@ > status = "disabled"; > }; > > + xhci: xhci@...00000 { According to Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml, this node should be called usb (but the label can be kept as xhci). > + compatible = "mediatek,mt8192-xhci", > + "mediatek,mtk-xhci"; > + reg = <0 0x11200000 0 0x1000>, > + <0 0x11203e00 0 0x0100>; > + reg-names = "mac", "ippc"; > + interrupts-extended = <&gic GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH 0>; > + interrupt-names = "host"; > + phys = <&u2port0 PHY_TYPE_USB2>, > + <&u3port0 PHY_TYPE_USB3>; > + assigned-clocks = <&topckgen CLK_TOP_USB_TOP_SEL>, > + <&topckgen CLK_TOP_SSUSB_XHCI_SEL>; > + assigned-clock-parents = <&topckgen CLK_TOP_UNIVPLL_D5_D4>, > + <&topckgen CLK_TOP_UNIVPLL_D5_D4>; > + clocks = <&infracfg CLK_INFRA_SSUSB>, > + <&infracfg CLK_INFRA_SSUSB_XHCI>, > + <&apmixedsys CLK_APMIXED_USBPLL>; > + clock-names = "sys_ck", "xhci_ck", "ref_ck"; > + wakeup-source; > + mediatek,syscon-wakeup = <&pericfg 0x420 102>; > + #address-cells = <2>; > + #size-cells = <2>; This node doesn't have any children, so no need for #address-cells and #size-cells, just drop them. Also, let's keep this node disabled by default: status = "disabled"; > + }; > + > nor_flash: spi@...34000 { > compatible = "mediatek,mt8192-nor"; > reg = <0 0x11234000 0 0xe0>; > -- > 2.18.0 > >
Powered by blists - more mailing lists