lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Feb 2022 13:17:02 -0800 From: Joe Perches <joe@...ches.com> To: Keith Busch <kbusch@...nel.org> Cc: David Laight <David.Laight@...lab.com>, Christoph Hellwig <hch@....de>, "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>, "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>, "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>, "x86@...nel.org" <x86@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "axboe@...nel.dk" <axboe@...nel.dk>, "martin.petersen@...cle.com" <martin.petersen@...cle.com>, "colyli@...e.de" <colyli@...e.de>, Bart Van Assche <bvanassche@....org> Subject: Re: [PATCHv3 04/10] linux/kernel: introduce lower_48_bits macro On Tue, 2022-02-22 at 13:12 -0800, Keith Busch wrote: > On Tue, Feb 22, 2022 at 12:31:30PM -0800, Joe Perches wrote: > > > I'd only use something GENMASK() for bit ranges. > > > Even then it is often easier to just write the value in hex. > > > > Mostly it's the count of the repeated f that's difficult to > > quickly verify visually. > > I admit I made this counting mistake in earlier versions of this series. It's simply hard for humans to do... https://en.wikipedia.org/wiki/Subitizing
Powered by blists - more mailing lists