| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202202230620.BKXzonUy-lkp@intel.com>
Date: Wed, 23 Feb 2022 06:39:30 +0800
From: kernel test robot <lkp@...el.com>
To: Phillip Potter <phil@...lpotter.co.uk>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: [staging:staging-next 55/83]
drivers/staging/r8188eu/hal/usb_halinit.c:1541:6: warning: variable 'arg'
set but not used
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
head: 7c6444d8e0f1be30e7fd910e40c0d495c36e6935
commit: db67ebf6b49cd6909f210ee44eb51d3cf2e39ae4 [55/83] staging: r8188eu: remove DBG_88E calls from hal subdir
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20220223/202202230620.BKXzonUy-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?id=db67ebf6b49cd6909f210ee44eb51d3cf2e39ae4
git remote add staging https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
git fetch --no-tags staging staging-next
git checkout db67ebf6b49cd6909f210ee44eb51d3cf2e39ae4
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/pinctrl/ drivers/remoteproc/ drivers/staging/r8188eu/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> drivers/staging/r8188eu/hal/usb_halinit.c:1541:6: warning: variable 'arg' set but not used [-Wunused-but-set-variable]
u8 arg;
^
1 warning generated.
vim +/arg +1541 drivers/staging/r8188eu/hal/usb_halinit.c
8cd574e6af5463a Phillip Potter 2021-07-28 1485
b561d2f0dc01ab0 Michael Straube 2021-09-06 1486 void UpdateHalRAMask8188EUsb(struct adapter *adapt, u32 mac_id, u8 rssi_level)
8cd574e6af5463a Phillip Potter 2021-07-28 1487 {
8cd574e6af5463a Phillip Potter 2021-07-28 1488 u8 init_rate = 0;
8cd574e6af5463a Phillip Potter 2021-07-28 1489 u8 networkType, raid;
8cd574e6af5463a Phillip Potter 2021-07-28 1490 u32 mask, rate_bitmap;
8cd574e6af5463a Phillip Potter 2021-07-28 1491 u8 shortGIrate = false;
8cd574e6af5463a Phillip Potter 2021-07-28 1492 int supportRateNum = 0;
8cd574e6af5463a Phillip Potter 2021-07-28 1493 struct sta_info *psta;
d904512db6f3727 Michael Straube 2021-12-07 1494 struct hal_data_8188e *haldata = &adapt->haldata;
8cd574e6af5463a Phillip Potter 2021-07-28 1495 struct mlme_ext_priv *pmlmeext = &adapt->mlmeextpriv;
6839ff57baa4a60 Michael Straube 2021-08-09 1496 struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
6839ff57baa4a60 Michael Straube 2021-08-09 1497 struct wlan_bssid_ex *cur_network = &pmlmeinfo->network;
8cd574e6af5463a Phillip Potter 2021-07-28 1498
8cd574e6af5463a Phillip Potter 2021-07-28 1499 if (mac_id >= NUM_STA) /* CAM_SIZE */
8cd574e6af5463a Phillip Potter 2021-07-28 1500 return;
8cd574e6af5463a Phillip Potter 2021-07-28 1501 psta = pmlmeinfo->FW_sta_info[mac_id].psta;
725a3f1c4d56b73 Michael Straube 2021-08-01 1502 if (!psta)
8cd574e6af5463a Phillip Potter 2021-07-28 1503 return;
8cd574e6af5463a Phillip Potter 2021-07-28 1504 switch (mac_id) {
8cd574e6af5463a Phillip Potter 2021-07-28 1505 case 0:/* for infra mode */
8cd574e6af5463a Phillip Potter 2021-07-28 1506 supportRateNum = rtw_get_rateset_len(cur_network->SupportedRates);
8cd574e6af5463a Phillip Potter 2021-07-28 1507 networkType = judge_network_type(adapt, cur_network->SupportedRates, supportRateNum) & 0xf;
8cd574e6af5463a Phillip Potter 2021-07-28 1508 raid = networktype_to_raid(networkType);
8cd574e6af5463a Phillip Potter 2021-07-28 1509 mask = update_supported_rate(cur_network->SupportedRates, supportRateNum);
6839ff57baa4a60 Michael Straube 2021-08-09 1510 mask |= (pmlmeinfo->HT_enable) ? update_MSC_rate(&pmlmeinfo->HT_caps) : 0;
6839ff57baa4a60 Michael Straube 2021-08-09 1511 if (support_short_GI(adapt, &pmlmeinfo->HT_caps))
8cd574e6af5463a Phillip Potter 2021-07-28 1512 shortGIrate = true;
8cd574e6af5463a Phillip Potter 2021-07-28 1513 break;
8cd574e6af5463a Phillip Potter 2021-07-28 1514 case 1:/* for broadcast/multicast */
8cd574e6af5463a Phillip Potter 2021-07-28 1515 supportRateNum = rtw_get_rateset_len(pmlmeinfo->FW_sta_info[mac_id].SupportedRates);
8cd574e6af5463a Phillip Potter 2021-07-28 1516 if (pmlmeext->cur_wireless_mode & WIRELESS_11B)
8cd574e6af5463a Phillip Potter 2021-07-28 1517 networkType = WIRELESS_11B;
8cd574e6af5463a Phillip Potter 2021-07-28 1518 else
8cd574e6af5463a Phillip Potter 2021-07-28 1519 networkType = WIRELESS_11G;
8cd574e6af5463a Phillip Potter 2021-07-28 1520 raid = networktype_to_raid(networkType);
8cd574e6af5463a Phillip Potter 2021-07-28 1521 mask = update_basic_rate(cur_network->SupportedRates, supportRateNum);
8cd574e6af5463a Phillip Potter 2021-07-28 1522 break;
8cd574e6af5463a Phillip Potter 2021-07-28 1523 default: /* for each sta in IBSS */
8cd574e6af5463a Phillip Potter 2021-07-28 1524 supportRateNum = rtw_get_rateset_len(pmlmeinfo->FW_sta_info[mac_id].SupportedRates);
8cd574e6af5463a Phillip Potter 2021-07-28 1525 networkType = judge_network_type(adapt, pmlmeinfo->FW_sta_info[mac_id].SupportedRates, supportRateNum) & 0xf;
8cd574e6af5463a Phillip Potter 2021-07-28 1526 raid = networktype_to_raid(networkType);
8cd574e6af5463a Phillip Potter 2021-07-28 1527 mask = update_supported_rate(cur_network->SupportedRates, supportRateNum);
8cd574e6af5463a Phillip Potter 2021-07-28 1528
8cd574e6af5463a Phillip Potter 2021-07-28 1529 /* todo: support HT in IBSS */
8cd574e6af5463a Phillip Potter 2021-07-28 1530 break;
8cd574e6af5463a Phillip Potter 2021-07-28 1531 }
8cd574e6af5463a Phillip Potter 2021-07-28 1532
8cd574e6af5463a Phillip Potter 2021-07-28 1533 rate_bitmap = 0x0fffffff;
8cd574e6af5463a Phillip Potter 2021-07-28 1534 rate_bitmap = ODM_Get_Rate_Bitmap(&haldata->odmpriv, mac_id, mask, rssi_level);
8cd574e6af5463a Phillip Potter 2021-07-28 1535
8cd574e6af5463a Phillip Potter 2021-07-28 1536 mask &= rate_bitmap;
8cd574e6af5463a Phillip Potter 2021-07-28 1537
8cd574e6af5463a Phillip Potter 2021-07-28 1538 init_rate = get_highest_rate_idx(mask) & 0x3f;
8cd574e6af5463a Phillip Potter 2021-07-28 1539
8cd574e6af5463a Phillip Potter 2021-07-28 1540 if (haldata->fw_ractrl) {
8cd574e6af5463a Phillip Potter 2021-07-28 @1541 u8 arg;
8cd574e6af5463a Phillip Potter 2021-07-28 1542
8cd574e6af5463a Phillip Potter 2021-07-28 1543 arg = mac_id & 0x1f;/* MACID */
8cd574e6af5463a Phillip Potter 2021-07-28 1544 arg |= BIT(7);
8cd574e6af5463a Phillip Potter 2021-07-28 1545 if (shortGIrate)
8cd574e6af5463a Phillip Potter 2021-07-28 1546 arg |= BIT(5);
8cd574e6af5463a Phillip Potter 2021-07-28 1547 mask |= ((raid << 28) & 0xf0000000);
8cd574e6af5463a Phillip Potter 2021-07-28 1548 psta->ra_mask = mask;
8cd574e6af5463a Phillip Potter 2021-07-28 1549 mask |= ((raid << 28) & 0xf0000000);
8cd574e6af5463a Phillip Potter 2021-07-28 1550
8cd574e6af5463a Phillip Potter 2021-07-28 1551 /* to do ,for 8188E-SMIC */
8cd574e6af5463a Phillip Potter 2021-07-28 1552 rtl8188e_set_raid_cmd(adapt, mask);
8cd574e6af5463a Phillip Potter 2021-07-28 1553 } else {
6839ff57baa4a60 Michael Straube 2021-08-09 1554 ODM_RA_UpdateRateInfo_8188E(&haldata->odmpriv,
8cd574e6af5463a Phillip Potter 2021-07-28 1555 mac_id,
8cd574e6af5463a Phillip Potter 2021-07-28 1556 raid,
8cd574e6af5463a Phillip Potter 2021-07-28 1557 mask,
8cd574e6af5463a Phillip Potter 2021-07-28 1558 shortGIrate
8cd574e6af5463a Phillip Potter 2021-07-28 1559 );
8cd574e6af5463a Phillip Potter 2021-07-28 1560 }
8cd574e6af5463a Phillip Potter 2021-07-28 1561 /* set ra_id */
8cd574e6af5463a Phillip Potter 2021-07-28 1562 psta->raid = raid;
8cd574e6af5463a Phillip Potter 2021-07-28 1563 psta->init_rate = init_rate;
8cd574e6af5463a Phillip Potter 2021-07-28 1564 }
8cd574e6af5463a Phillip Potter 2021-07-28 1565
:::::: The code at line 1541 was first introduced by commit
:::::: 8cd574e6af5463af7d693d111c61212e52c44810 staging: r8188eu: introduce new hal dir for RTL8188eu driver
:::::: TO: Phillip Potter <phil@...lpotter.co.uk>
:::::: CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists