linux-kernel - Re: [PATCH v1] drivers/base/memory: clarify adding and removing of memory blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YhR5coy7OGyjwQtx@localhost.localdomain>
Date:   Tue, 22 Feb 2022 06:49:38 +0100
From:   Oscar Salvador <osalvador@...e.de>
To:     David Hildenbrand <david@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH v1] drivers/base/memory: clarify adding and removing of
 memory blocks

On Mon, Feb 21, 2022 at 04:45:31PM +0100, David Hildenbrand wrote:
> Let's make it clearer at which places we actually add and remove memory
> blocks -- streamlining the terminology -- and highlight which memory
> block start out online and which start out as offline.
> 
> * rename add_memory_block -> add_boot_memory_block
> * rename init_memory_block -> add_memory_block
> * rename unregister_memory -> remove_memory_block
> * rename register_memory -> __add_memory_block
> * add add_hotplug_memory_block
> * mark add_boot_memory_block with __init (suggested by Oscar)
> 
> __add_memory_block() is  a pure helper for add_memory_block(), remove
> the somewhat obvious comment.
> 
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Michal Hocko <mhocko@...e.com>
> Cc: Oscar Salvador <osalvador@...e.de>
> Signed-off-by: David Hildenbrand <david@...hat.com>

Thanks for doing this, it makes the code much more clear.

Reviewed-by: Oscar Salvador <osalvador@...e.de>

> ---
> 
> Based on v5.17-rc5 and:
> 	[PATCH v2 0/2] drivers/base/memory: determine and store zone for
> 	single-zone memory blocks [1]

Maybe just my thing, but I also had to pull in [1] in order to apply
this error-free. 

[1] https://patchwork.kernel.org/project/linux-mm/patch/20220128144540.153902-1-david@redhat.com/


-- 
Oscar Salvador
SUSE Labs