linux-kernel - Re: [PATCH] devlink: use devlink lock on DEVLINK_CMD_PORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220221205442.20da7c35@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Mon, 21 Feb 2022 20:54:42 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Niels Dossche <niels.dossche@...nt.be>
Cc:     Jiri Pirko <jiri@...dia.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] devlink: use devlink lock on DEVLINK_CMD_PORT_SPLIT

On Mon, 21 Feb 2022 14:33:25 +0100 Niels Dossche wrote:
> devlink_nl_cmd_port_split_doit is executed without taking the devlink
> instance lock. This function calls to devlink_port_get_from_info, which
> calls devlink_port_get_from_attrs, which calls
> devlink_port_get_by_index, which accesses devlink->port_list without the
> instance lock taken, while in other places devlink->port_list access
> always happens with the instance lock taken. The documentation in the
> struct also say that the devlink lock protects the port_list.
> 
> The flag for no locking was added after refactoring the code to no
> longer use a global lock.
> 
> Fixes: 2406e7e546b2 ("devlink: Add per devlink instance lock")
> Signed-off-by: Niels Dossche <niels.dossche@...nt.be>

You can't do this, driver will likely try to register ports and try 
to re-acquire the same lock. I have a series queued to fix this by
moving the locking into drivers. I'll send it out this week.