linux-kernel - Re: [PATCH] mesh: Stop using struct scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YhSYWUeOZ20s2qZI@infradead.org>
Date:   Tue, 22 Feb 2022 00:01:29 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Finn Thain <fthain@...ux-m68k.org>
Cc:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mesh: Stop using struct scsi_pointer

On Tue, Feb 22, 2022 at 10:09:42AM +1100, Finn Thain wrote:
> This driver doesn't use SCp.ptr to save a SCSI command data pointer
> which means "scsi pointer" is a complete misnomer here. Only a few
> members of struct scsi_pointer are used and the rest waste memory.
> Avoid the "struct foo { struct bar; };" silliness.

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>