linux-kernel - Re: [PATCH v6 09/13] module: Move kallsyms support into a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2202221055470.15071@pobox.suse.cz>
Date:   Tue, 22 Feb 2022 10:58:13 +0100 (CET)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Aaron Tomlin <atomlin@...hat.com>
cc:     Christophe Leroy <christophe.leroy@...roup.eu>,
        "Luis R. Rodriguez" <mcgrof@...nel.org>,
        "Lameter, Christoph" <cl@...ux.com>,
        Petr Mladek <pmladek@...e.com>,
        Andrew Morton <akpm@...ux-foundation.org>, jeyu@...nel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-modules@...r.kernel.org, live-patching@...r.kernel.org,
        Aaron Tomlin <atomlin@...mlin.com>,
        Grzegorz Halat <ghalat@...hat.com>,
        Allen <allen.lkml@...il.com>, Joe Perches <joe@...ches.com>,
        Michal Suchanek <msuchanek@...e.de>, oleksandr@...alenko.name
Subject: Re: [PATCH v6 09/13] module: Move kallsyms support into a separate
 file

On Mon, 21 Feb 2022, Aaron Tomlin wrote:

> On Mon 2022-02-21 09:35 +0100, Christophe Leroy wrote:
> > Fixup:
> >
> > diff --git a/kernel/module/kallsyms.c b/kernel/module/kallsyms.c
> > index 6c8f1f390cf5..2ee8d2e67068 100644
> > --- a/kernel/module/kallsyms.c
> > +++ b/kernel/module/kallsyms.c
> > @@ -171,8 +171,7 @@ void add_kallsyms(struct module *mod, const struct
> > load_info *info)
> >      Elf_Shdr *symsec = &info->sechdrs[info->index.sym];
> >
> >      /* Set up to point into init section. */
> > -    mod->kallsyms = (struct mod_kallsyms __rcu *)mod->init_layout.base +
> > -        info->mod_kallsyms_init_off;
> > +    mod->kallsyms = (void __rcu *)mod->init_layout.base +
> > info->mod_kallsyms_init_off;
> >
> >      /* The following is safe since this pointer cannot change */
> >      rcu_dereference_sched(mod->kallsyms)->symtab = (void *)symsec->sh_addr;
> 
> Agreed.

Could you split all of this to a follow-up patch, please? So that 9/13 is 
really only about moving the code.

Btw, the sparse warnings "dereference of noderef expression" appeared 
after 5/13 of the series which moved latched RB-tree support, so it does 
not belong here anyway.

Miroslav