linux-kernel - Re: [PATCH v3] ath9k: use hw_random API instead of directly dumping into random.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXFLx1xGexd5P9xnB-2=cFn1DScCa8U6a7AyRAxQPLCWLw@mail.gmail.com>
Date:   Tue, 22 Feb 2022 11:01:34 +0100
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Kalle Valo <kvalo@...nel.org>
Cc:     "Jason A. Donenfeld" <Jason@...c4.com>, miaoqing@...eaurora.org,
        Rui Salvaterra <rsalvaterra@...il.com>,
        Toke Høiland-Jørgensen <toke@...e.dk>,
        "Sepehrdad, Pouyan" <pouyans@....qualcomm.com>,
        ath9k-devel <ath9k-devel@....qualcomm.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        LKML <linux-kernel@...r.kernel.org>,
        Netdev <netdev@...r.kernel.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH v3] ath9k: use hw_random API instead of directly dumping
 into random.c

On Mon, 21 Feb 2022 at 11:57, Kalle Valo <kvalo@...nel.org> wrote:
>
> "Jason A. Donenfeld" <Jason@...c4.com> wrote:
>
> > Hardware random number generators are supposed to use the hw_random
> > framework. This commit turns ath9k's kthread-based design into a proper
> > hw_random driver.
> >
> > Cc: Toke Høiland-Jørgensen <toke@...hat.com>
> > Cc: Kalle Valo <kvalo@...nel.org>
> > Cc: Rui Salvaterra <rsalvaterra@...il.com>
> > Cc: Dominik Brodowski <linux@...inikbrodowski.net>
> > Cc: Herbert Xu <herbert@...dor.apana.org.au>
> > Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> > Tested-by: Rui Salvaterra <rsalvaterra@...il.com>
> > Acked-by: Toke Høiland-Jørgensen <toke@...e.dk>
> > Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>
>
> Patch applied to ath-next branch of ath.git, thanks.
>
> fcd09c90c3c5 ath9k: use hw_random API instead of directly dumping into random.c
>

With this patch, it seems we end up registering the hw_rng every time
the link goes up, and unregister it again when the link goes down,
right?

Wouldn't it be better to split off this driver from the 802.11 link
state handling?