linux-kernel - Re: [PATCH v2] KVM:VMX:Remove scratch 'cpu' variable that shadows an identical scratch var

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YhT+a4I0ytA7eVE5@google.com>
Date:   Tue, 22 Feb 2022 15:16:59 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Peng Hao <flyingpenghao@...il.com>
Cc:     pbonzini@...hat.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] KVM:VMX:Remove scratch 'cpu' variable that shadows an
 identical scratch var

Needs a space between "KVM:" and "VMX:".  No need to resend, Paolo can fixup when
applying.

On Tue, Feb 22, 2022, Peng Hao wrote:
>  From: Peng Hao <flyingpeng@...cent.com> 
> 
>  Remove a redundant 'cpu' declaration from inside an if-statement that
>  that shadows an identical declaration at function scope.  Both variables
>  are used as scratch variables in for_each_*_cpu() loops, thus there's no
>  harm in sharing a variable.
> 
> Reviewed-by: Sean Christopherson <seanjc@...gle.com>
> Signed-off-by: Peng Hao <flyingpeng@...cent.com>
> ---
>  arch/x86/kvm/vmx/vmx.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index ba66c171d951..6101c2980a9c 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -7931,7 +7931,6 @@ static int __init vmx_init(void)
>  	    ms_hyperv.hints & HV_X64_ENLIGHTENED_VMCS_RECOMMENDED &&
>  	    (ms_hyperv.nested_features & HV_X64_ENLIGHTENED_VMCS_VERSION) >=
>  	    KVM_EVMCS_VERSION) {
> -		int cpu;
>  
>  		/* Check that we have assist pages on all online CPUs */
>  		for_each_online_cpu(cpu) {
> -- 
> 2.27.0
>