linux-kernel - Re: [PATCH v3 3/4] x86/mce, EDAC/mce_amd: Cache MCA_CONFIG[McaX] in struct mce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YhUC1wW0mxC/Dmpv@zn.tnic>
Date:   Tue, 22 Feb 2022 16:35:51 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>
Cc:     x86@...nel.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org, Tony Luck <tony.luck@...el.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rric@...nel.org>,
        Yazen Ghannam <yazen.ghannam@....com>
Subject: Re: [PATCH v3 3/4] x86/mce, EDAC/mce_amd: Cache MCA_CONFIG[McaX] in
 struct mce_bank

On Fri, Feb 11, 2022 at 04:34:41PM -0600, Smita Koralahalli wrote:
> Cache the value of MCA_CONFIG[McaX] in the existing mce_bank struct
> similar to MCA_CONFIG[McaLsbInStatusSupported].
> 
> This simplifies and eliminates the need to read MCA_CONFIG register each
> time to check McaX.

I don't see the point for this change, frankly.

I doubt it is speed because those are not really hot paths.

Code savings ain't either: 5 files changed, 36 insertions(+), 22 deletions(-)

Having yet another exported function to modules if not really necessary
doesn't make it prettier too.

So if there's no point for it, you can simply drop it.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette