linux-kernel - Re: [PATCH v1 1/1] misc: bcm-vk: add kconfig for supporting viper chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Feb 2022 07:41:04 -0800
From:   "Desmond Yan (APD)" <desmond.yan@...adcom.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Scott Branden <scott.branden@...adcom.com>,
        Arnd Bergmann <arnd@...db.de>,
        bcm-kernel-feedback-list@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] misc: bcm-vk: add kconfig for supporting viper chip

Greg,

This is to allow the customer to use their own driver, by default,
which is their preferred option.

thx
Des


On Fri, Feb 18, 2022 at 11:33 PM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Fri, Feb 18, 2022 at 12:08:11PM -0800, Desmond Yan wrote:
> > Add kconfig for enabling bcm-vk driver to support the viper chip.
> > Default is off and only explicitly configured that the viper chip
> > would be discovered by the driver and loaded for usage.
> >
> > Tested-by: Desmond Yan <desmond.yan@...adcom.com>
> > Signed-off-by: Desmond Yan <desmond.yan@...adcom.com>
> > ---
> >  drivers/misc/bcm-vk/Kconfig      | 10 ++++++++++
> >  drivers/misc/bcm-vk/bcm_vk_dev.c |  2 ++
> >  2 files changed, 12 insertions(+)
> >
> > diff --git a/drivers/misc/bcm-vk/Kconfig b/drivers/misc/bcm-vk/Kconfig
> > index 68a972772b99..43910a378163 100644
> > --- a/drivers/misc/bcm-vk/Kconfig
> > +++ b/drivers/misc/bcm-vk/Kconfig
> > @@ -16,6 +16,16 @@ config BCM_VK
> >
> >         If unsure, say N.
> >
> > +config BCM_VK_VIPER
> > +     bool "VK driver for VIPER"
> > +     depends on BCM_VK
> > +     help
> > +       Turn on to enable using the vk driver for the viper variant.
> > +       Used for development environments where viper uses VK driver
> > +       and VK firmware rather than an alternate firmware and driver.
> > +
> > +       If unsure, say N.
> > +
> >  config BCM_VK_TTY
> >       bool "Enable tty ports on a Broadcom VK Accelerator device"
> >       depends on TTY
> > diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_dev.c
> > index ad639ee85b2a..41dbfa4fa4a5 100644
> > --- a/drivers/misc/bcm-vk/bcm_vk_dev.c
> > +++ b/drivers/misc/bcm-vk/bcm_vk_dev.c
> > @@ -1633,7 +1633,9 @@ static void bcm_vk_shutdown(struct pci_dev *pdev)
> >
> >  static const struct pci_device_id bcm_vk_ids[] = {
> >       { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VALKYRIE), },
> > +#if defined(CONFIG_BCM_VK_VIPER)
> >       { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VIPER), },
> > +#endif
>
> Why do you need a new config option just to add a new device id?  Why
> would you ever NOT want this option enabled as there is no other driver
> for this hardware?
>
> thanks,
>
> greg k-h

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4206 bytes)