linux-kernel - Re: [PATCH 03/10] drm/amdgpu: Remove unused get_umc_v8_7_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Feb 2022 11:29:58 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Maíra Canal <maira.canal@....br>
Cc:     "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        xinhui pan <Xinhui.Pan@....com>,
        Hawking Zhang <Hawking.Zhang@....com>,
        John Clements <john.clements@....com>,
        Tao Zhou <tao.zhou1@....com>,
        "Chai, Thomas" <YiPeng.Chai@....com>,
        "Tuikov, Luben" <luben.tuikov@....com>,
        "Stanley.Yang" <Stanley.Yang@....com>,
        Dennis Li <Dennis.Li@....com>,
        "Joshi, Mukul" <mukul.joshi@....com>,
        "Wentland, Harry" <harry.wentland@....com>,
        "Leo (Sunpeng) Li" <sunpeng.li@....com>,
        "Siqueira, Rodrigo" <Rodrigo.Siqueira@....com>,
        Anthony Koo <Anthony.Koo@....com>,
        Magali Lemes <magalilemes00@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>, mwen@...lia.com,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Isabella Basso <isabbasso@...eup.net>
Subject: Re: [PATCH 03/10] drm/amdgpu: Remove unused get_umc_v8_7_channel_index
 function

Applied.  Thanks!

Alex

On Tue, Feb 22, 2022 at 8:17 AM Maíra Canal <maira.canal@....br> wrote:
>
> Remove get_umc_v8_7_channel_index function, which is not used
> in the codebase.
>
> This was pointed by clang with the following warning:
>
> drivers/gpu/drm/amd/amdgpu/umc_v8_7.c:50:24: warning: unused function
> 'get_umc_v8_7_channel_index' [-Wunused-function]
> static inline uint32_t get_umc_v8_7_channel_index(struct amdgpu_device *adev,
>                        ^
>
> Signed-off-by: Maíra Canal <maira.canal@....br>
> ---
>  drivers/gpu/drm/amd/amdgpu/umc_v8_7.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c b/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c
> index de85a998ef99..f35253e0eaa6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c
> +++ b/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c
> @@ -47,13 +47,6 @@ static inline uint32_t get_umc_v8_7_reg_offset(struct amdgpu_device *adev,
>         return adev->umc.channel_offs*ch_inst + UMC_8_INST_DIST*umc_inst;
>  }
>
> -static inline uint32_t get_umc_v8_7_channel_index(struct amdgpu_device *adev,
> -                                               uint32_t umc_inst,
> -                                               uint32_t ch_inst)
> -{
> -       return adev->umc.channel_idx_tbl[umc_inst * adev->umc.channel_inst_num + ch_inst];
> -}
> -
>  static void umc_v8_7_ecc_info_query_correctable_error_count(struct amdgpu_device *adev,
>                                                 uint32_t umc_inst, uint32_t ch_inst,
>                                                 unsigned long *error_count)
> --
> 2.35.1
>