linux-kernel - Re: [PATCH 05/10] drm/amd/display: Remove unused dcn316_smu_set_voltage_via

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Feb 2022 11:32:13 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Maíra Canal <maira.canal@....br>
Cc:     "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        xinhui pan <Xinhui.Pan@....com>,
        Hawking Zhang <Hawking.Zhang@....com>,
        John Clements <john.clements@....com>,
        Tao Zhou <tao.zhou1@....com>,
        "Chai, Thomas" <YiPeng.Chai@....com>,
        "Tuikov, Luben" <luben.tuikov@....com>,
        "Stanley.Yang" <Stanley.Yang@....com>,
        Dennis Li <Dennis.Li@....com>,
        "Joshi, Mukul" <mukul.joshi@....com>,
        "Wentland, Harry" <harry.wentland@....com>,
        "Leo (Sunpeng) Li" <sunpeng.li@....com>,
        "Siqueira, Rodrigo" <Rodrigo.Siqueira@....com>,
        Anthony Koo <Anthony.Koo@....com>,
        Magali Lemes <magalilemes00@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>, mwen@...lia.com,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Isabella Basso <isabbasso@...eup.net>
Subject: Re: [PATCH 05/10] drm/amd/display: Remove unused dcn316_smu_set_voltage_via_phyclk
 function

Applied.  Thanks!

Alex

On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal <maira.canal@....br> wrote:
>
> Remove dcn316_smu_set_voltage_via_phyclk function, which is not used in the
> codebase.
>
> This was pointed by clang with the following warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_smu.c:171:5:
> warning: no previous prototype for function
> 'dcn316_smu_set_voltage_via_phyclk' [-Wmissing-prototypes]
> int dcn316_smu_set_voltage_via_phyclk(struct clk_mgr_internal *clk_mgr, int
> requested_phyclk_khz)
>     ^
>
> Signed-off-by: Maíra Canal <maira.canal@....br>
> ---
>  .../amd/display/dc/clk_mgr/dcn316/dcn316_smu.c   | 16 ----------------
>  1 file changed, 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c
> index b7f9e1b34c11..fd6497fd2dc5 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c
> @@ -168,22 +168,6 @@ int dcn316_smu_set_dispclk(struct clk_mgr_internal *clk_mgr, int requested_dispc
>         return actual_dispclk_set_mhz * 1000;
>  }
>
> -int dcn316_smu_set_voltage_via_phyclk(struct clk_mgr_internal *clk_mgr, int requested_phyclk_khz)
> -{
> -       int actual_phypclk_set_mhz = -1;
> -
> -       if (!clk_mgr->smu_present && requested_phyclk_khz)
> -               return requested_phyclk_khz;
> -
> -       /*  Unit of SMU msg parameter is Mhz */
> -       actual_phypclk_set_mhz = dcn316_smu_send_msg_with_param(
> -                       clk_mgr,
> -                       VBIOSSMC_MSG_SetPhyclkVoltageByFreq,
> -                       khz_to_mhz_ceil(requested_phyclk_khz));
> -
> -       return actual_phypclk_set_mhz * 1000;
> -}
> -
>  int dcn316_smu_set_hard_min_dcfclk(struct clk_mgr_internal *clk_mgr, int requested_dcfclk_khz)
>  {
>         int actual_dcfclk_set_mhz = -1;
> --
> 2.35.1
>