linux-kernel - Re: Unintended file entry addition in commit 7ed88a03b15b ("certs: Check that builtin blacklist hashes are valid")?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YhZXoPqSdfdXEfgx@iki.fi>
Date:   Wed, 23 Feb 2022 16:49:52 +0100
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Mickaël Salaün <mic@...ux.microsoft.com>,
        "open list:ASYMMETRIC KEYS" <keyrings@...r.kernel.org>,
        linux-crypto@...r.kernel.org, linux-integrity@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Unintended file entry addition in commit 7ed88a03b15b ("certs:
 Check that builtin blacklist hashes are valid")?

On Wed, Feb 23, 2022 at 02:50:42PM +0100, Lukas Bulwahn wrote:
> Dear Jarkko, dear Mickaël,
> 
> The commit 7ed88a03b15b ("certs: Check that builtin blacklist hashes
> are valid") adds a file entry for scripts/extract-cert.c in the
> CERTIFICATE HANDLING section in MAINTAINERS.
> 
> Hence, ./scripts/get_maintainers.pl --self-test=patterns complains:
> 
>   warning:  no file matches  F: scripts/extract-cert.c
> 
> I could not see that line being added in the original patch, i.e.,
> https://lore.kernel.org/all/20210712170313.884724-3-mic@digikod.net/,
> but it was only part of the context of that patch. In linux-next, it
> appears to be part of the commit above.
> 
> That seems to be introduced while applying or rebasing the patch to
> some later version. If that is the case, you can probably just drop
> this line "F: scripts/extract-cert.c" in the MAINTAINERS file.

Thank you, I removed the entry. I had to solve a merge conflict with
this patch, and made a human error.

BR, Jarkko