linux-kernel - Re: [PATCH] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220223163640.flnyrxp33rpadevr@unable>
Date:   Wed, 23 Feb 2022 10:36:40 -0600
From:   Nishanth Menon <nm@...com>
To:     Aparna M <a-m1@...com>
CC:     <vigneshr@...com>, <kristo@...nel.org>, <robh+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <praneeth@...com>, <grygorii.strashko@...com>, <nikhil.nd@...com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard
 LEDs

On 21:48-20220223, Aparna M wrote:
> On 07:55-20220223, Nishanth Menon wrote:
> > On 14:02-20220223, Aparna M wrote:
> > > AM642 SK has 8 leds connected to tpic2810 onboard. Add support for these
> > > gpio leds.
> > > 
> > > Signed-off-by: Aparna M <a-m1@...com>
> > > ---
> > >  arch/arm64/boot/dts/ti/k3-am642-sk.dts | 70 ++++++++++++++++++++++++++
> > >  1 file changed, 70 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> > > index 6b04745147be..31e45bafa49e 100644
> > > --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> > [...]
> > 
> > > +
> > > +	exp2: gpio@60 {
> > > +		compatible = "ti,tpic2810";
> > 
> > Sorry, but no.
> > please convert
> > 	Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt to yaml
> > 
> > prior to any patches that enable it. (dtbs_check should have already
> > warned you about this).
> 
> A patch for changing binding to yaml has already been sent. 
> Link to patchwork: https://patchwork.ozlabs.org/project/linux-gpio/patch/20220223072308.31868-1-a-m1@ti.com/

you have errors that you need to address. once the patch gets to
mainline master branch, then we can consider this patch.

Also in the future, when there is dependency such as these, you should
indicate that in the diffstat section rather than expecting maintainers
to go searching (we wont).

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D