linux-kernel - Re: [PATCH 03/12] mm/damon: Implement a minimal stub for sysfs-based DAMON interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220223164513.23089-1-sj@kernel.org>
Date:   Wed, 23 Feb 2022 16:45:13 +0000
From:   SeongJae Park <sj@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     SeongJae Park <sj@...nel.org>, akpm@...ux-foundation.org,
        corbet@....net, skhan@...uxfoundation.org, rientjes@...gle.com,
        xhao@...ux.alibaba.com, linux-damon@...zon.com, linux-mm@...ck.org,
        linux-doc@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/12] mm/damon: Implement a minimal stub for sysfs-based DAMON interface

On Wed, 23 Feb 2022 17:09:38 +0100 Greg KH <gregkh@...uxfoundation.org> wrote:

> On Wed, Feb 23, 2022 at 03:20:42PM +0000, SeongJae Park wrote:
> > +static struct kobj_attribute damon_sysfs_ul_range_min_attr =
> > +		__ATTR(min, 0600, damon_sysfs_ul_range_min_show,
> > +				damon_sysfs_ul_range_min_store);
> > +
> > +static struct kobj_attribute damon_sysfs_ul_range_max_attr =
> > +		__ATTR(max, 0600, damon_sysfs_ul_range_max_show,
> > +				damon_sysfs_ul_range_max_store);
> 
> Can you use __ATTR_RW_MODE() instead here and elsewhere?

Sure, I will, in the next revision.


Thanks,
SJ

> 
> thanks,
> 
> greg k-h
>