linux-kernel - Re: [PATCH] Documentation/vm/page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b6fe797-4d85-610e-7b7b-8c8295cc307d@infradead.org>
Date:   Wed, 23 Feb 2022 09:16:30 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Yixuan Cao <caoyixuan2019@...il.szu.edu.cn>, corbet@....net
Cc:     akpm@...ux-foundation.org, sfr@...b.auug.org.au,
        hanshenghong2019@...il.szu.edu.cn, weizhenliang@...wei.com,
        georgi.djakov@...aro.org, skhan@...uxfoundation.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation/vm/page_owner.rst: fix commends

Hi,

On 2/23/22 05:41, Yixuan Cao wrote:
> There are some commends that need to be fixed.
> 
> Thanks for Shuah Khan's constructive suggestions.
> The commends have been fixed as follows.
> 
> a. So, if you'd like to use it, you need
> to add "page_owner=on" into your boot cmdline.
> 
> Here, "into" has been replaced with "to".
> 
> b. ...page owner is disabled in runtime due to no
> enabling, boot option, runtime overhead is marginal.
> 
> Here, "no" has been replaced with "not".
> 
> Signed-off-by: Yixuan Cao <caoyixuan2019@...il.szu.edu.cn>

The file changes look good.
The Subject and patch description should use "comments"
instead of "commends".

thanks.

Acked-by: Randy Dunlap <rdunlap@...radead.org>

> ---
>  Documentation/vm/page_owner.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/vm/page_owner.rst b/Documentation/vm/page_owner.rst
> index 2b54e82b9fe1..aec1906976f4 100644
> --- a/Documentation/vm/page_owner.rst
> +++ b/Documentation/vm/page_owner.rst
> @@ -26,9 +26,9 @@ fragmentation statistics can be obtained through gfp flag information of
>  each page. It is already implemented and activated if page owner is
>  enabled. Other usages are more than welcome.
>  
> -page owner is disabled in default. So, if you'd like to use it, you need
> -to add "page_owner=on" into your boot cmdline. If the kernel is built
> -with page owner and page owner is disabled in runtime due to no enabling
> +page owner is disabled by default. So, if you'd like to use it, you need
> +to add "page_owner=on" to your boot cmdline. If the kernel is built
> +with page owner and page owner is disabled in runtime due to not enabling
>  boot option, runtime overhead is marginal. If disabled in runtime, it
>  doesn't require memory to store owner information, so there is no runtime
>  memory overhead. And, page owner inserts just two unlikely branches into

-- 
~Randy