linux-kernel - Re: [PATCH v5 1/2] mm/hwpoison: Avoid the impact of hwpoison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YhZxWjei2Iw65mAF@zn.tnic>
Date:   Wed, 23 Feb 2022 18:39:38 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     luofei <luofei@...cloud.com>
Cc:     tony.luck@...el.com, tglx@...utronix.de, mingo@...hat.com,
        dave.hansen@...ux.intel.com, x86@...nel.org,
        naoya.horiguchi@....com, akpm@...ux-foundation.org, hpa@...or.com,
        gregkh@...uxfoundation.org, rafael@...nel.org,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH v5 1/2] mm/hwpoison: Avoid the impact of
 hwpoison_filter() return value on mce handler

On Wed, Feb 23, 2022 at 03:21:35AM -0500, luofei wrote:
> When the hwpoison page meets the filter conditions, it should
> not be regarded as successful memory_failure() processing for
> mce handler, but should return a distinct value, otherwise
> mce handler regards the error page has been identified and
> isolated, which may lead to calling set_mce_nospec() to change
> page attribute, etc.
> 
> Here memory_failure() return -EOPNOTSUPP to indicate that the
> error event is filtered, mce handler should not take any action
> for this situation and hwpoison injector should treat as correct.
> 
> Signed-off-by: luofei <luofei@...cloud.com>
> ---
>  arch/x86/kernel/cpu/mce/core.c | 8 +++++---
>  drivers/base/memory.c          | 2 ++
>  mm/hwpoison-inject.c           | 3 ++-
>  mm/madvise.c                   | 2 ++
>  mm/memory-failure.c            | 9 +++++++--
>  5 files changed, 18 insertions(+), 6 deletions(-)

Much better, thanks.

Acked-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette