linux-kernel - Re: [PATCH v3] simplefb: Enable boot time VESA graphic mode selection.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220223182341.GG3113@kunlun.suse.cz>
Date:   Wed, 23 Feb 2022 19:23:41 +0100
From:   Michal Suchánek <msuchanek@...e.de>
To:     Javier Martinez Canillas <javierm@...hat.com>
Cc:     dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, Martin Mares <mj@....cz>,
        Helge Deller <deller@....de>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Sudeep Holla <sudeep.holla@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Cristian Marussi <cristian.marussi@....com>,
        Simon Trimmer <simont@...nsource.cirrus.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Arnd Bergmann <arnd@...db.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Rob Herring <robh@...nel.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        David Herrmann <dh.herrmann@...il.com>,
        linux-kernel@...r.kernel.org, linux-video@...ey.karlin.mff.cuni.cz
Subject: Re: [PATCH v3] simplefb: Enable boot time VESA graphic mode
 selection.

On Wed, Feb 23, 2022 at 07:13:07PM +0100, Javier Martinez Canillas wrote:
> On 2/23/22 18:12, Michal Suchánek wrote:
> > On Wed, Feb 23, 2022 at 05:54:54PM +0100, Javier Martinez Canillas wrote:
> 
> [snip]
> 
> >>
> >> Yes, that's what I tried to say. But your commit message says "To enable
> >> use of VESA modes with simplefb in legacy BIOS boot mode" and that isn't
> >> accurate AFAIU (unless you meant sysfb instead).
> > 
> >  config SYSFB_SIMPLEFB
> >         bool "Mark VGA/VBE/EFI FB as generic system framebuffer"
> >         depends on SYSFB
> > +       select BOOT_VESA_SUPPORT if X86
> > 
> > This to me means that it's simplefb specifically that requires it, not sysfb.
> > More precisely SYSFB_SIMPLEFB which is the simplefb implementation on top of
> > legacy BIOS.
> > 
> 
> Ok, I see what you meant. The fact that simplefb is what's named to the part
> of the sysfb driver that register the "simple-framebuffer" platform device
> and also the name of the fbdev driver that matches the "simple-framebuffer"
> is too confusing.
> 
> My point about the subject line remains thought, I would use something like:
> 
> firmware: sysfb: Enable boot time VESA graphic mode selection for simplefb

I see where the confusion comes from.

The efifb (and probably vesafb) has implicit unstated dependency on
sysfb. So the drivers that select BOOT_VESA_SUPPORT should instead
depend on SYSFB, and then SYSFB can select BOOT_VESA_SUPPORT, and it
will look much saner.

Thanks

Michal