linux-kernel - [nbd168-wireless:mtk-flow-offload 15/15] drivers/net/ethernet/mediatek/mtk_ppe.c:446:28: warning: variable 'head' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202202240359.nIypTA36-lkp@intel.com>
Date:   Thu, 24 Feb 2022 03:36:00 +0800
From:   kernel test robot <lkp@...el.com>
To:     Felix Fietkau <nbd@....name>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [nbd168-wireless:mtk-flow-offload 15/15]
 drivers/net/ethernet/mediatek/mtk_ppe.c:446:28: warning: variable 'head' set
 but not used

tree:   https://github.com/nbd168/wireless mtk-flow-offload
head:   4dded169141416b3248146f545378f36cca6bd03
commit: 4dded169141416b3248146f545378f36cca6bd03 [15/15] net: ethernet: mtk_eth_soc: support creating mac address based offload entries
config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20220224/202202240359.nIypTA36-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/nbd168/wireless/commit/4dded169141416b3248146f545378f36cca6bd03
        git remote add nbd168-wireless https://github.com/nbd168/wireless
        git fetch --no-tags nbd168-wireless mtk-flow-offload
        git checkout 4dded169141416b3248146f545378f36cca6bd03
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash drivers/net/ethernet/mediatek/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/mediatek/mtk_ppe.c: In function 'mtk_flow_entry_update_l2':
>> drivers/net/ethernet/mediatek/mtk_ppe.c:446:28: warning: variable 'head' set but not used [-Wunused-but-set-variable]
     446 |         struct hlist_head *head;
         |                            ^~~~


vim +/head +446 drivers/net/ethernet/mediatek/mtk_ppe.c

   440	
   441	static void
   442	mtk_flow_entry_update_l2(struct mtk_ppe *ppe, struct mtk_flow_entry *entry)
   443	{
   444		struct mtk_flow_entry *cur;
   445		struct mtk_foe_entry *hwe;
 > 446		struct hlist_head *head;
   447		struct hlist_node *tmp;
   448		int idle;
   449	
   450		idle = __mtk_foe_entry_idle_time(ppe, entry->data.ib1);
   451		head = &entry->l2_flows;
   452		hlist_for_each_entry_safe(cur, tmp, &entry->l2_flows, l2_data.list) {
   453			int cur_idle;
   454			u32 ib1;
   455	
   456			hwe = &ppe->foe_table[cur->hash];
   457			ib1 = READ_ONCE(hwe->ib1);
   458	
   459			if (FIELD_GET(MTK_FOE_IB1_STATE, ib1) != MTK_FOE_STATE_BIND) {
   460				cur->hash = 0xffff;
   461				__mtk_foe_entry_clear(ppe, cur);
   462				continue;
   463			}
   464	
   465			cur_idle = __mtk_foe_entry_idle_time(ppe, ib1);
   466			if (cur_idle >= idle)
   467				continue;
   468	
   469			idle = cur_idle;
   470			entry->data.ib1 &= ~MTK_FOE_IB1_BIND_TIMESTAMP;
   471			entry->data.ib1 |= hwe->ib1 & MTK_FOE_IB1_BIND_TIMESTAMP;
   472		}
   473	}
   474	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org