lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CA+khW7hKQcJ30om+XzrCa-Aj=r9eHAHETS=7qtVW6+t480w2uQ@mail.gmail.com> Date: Wed, 23 Feb 2022 15:40:16 -0800 From: Hao Luo <haoluo@...gle.com> To: Greg Thelen <gthelen@...gle.com> Cc: Andrii Nakryiko <andrii.nakryiko@...il.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, Song Liu <songliubraving@...com>, Namhyung Kim <namhyung@...nel.org>, Blake Jones <blakejones@...gle.com>, bpf <bpf@...r.kernel.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH bpf-next] bpf: Cache the last valid build_id. On Wed, Feb 23, 2022 at 3:16 PM Greg Thelen <gthelen@...gle.com> wrote: > > Andrii Nakryiko <andrii.nakryiko@...il.com> wrote: > > > > > as a further optimization, shouldn't we first check if ips[i] is > > within prev_vma and avoid rbtree walk altogether? Would this work: > > > > if (prev_vma && range_in_vma(prev_vma, ips[i])) { > > /* reuse build_id */ > > } > > vma = find_vma(current->mm, ips[i]); > > > > > > ? > > Yes, that's a nice addition. Good idea. Yes, great point! I noticed range_in_vma() already has a check on the null-ness of prev_vma. I am going to send a v2.
Powered by blists - more mailing lists