| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202202230809.3HxMqsaH-lkp@intel.com>
Date: Wed, 23 Feb 2022 08:32:20 +0800
From: kernel test robot <lkp@...el.com>
To: hanchuanhua <hanchuanhua@...o.com>
Cc: kbuild-all@...ts.01.org,
GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
linux-kernel@...r.kernel.org, Palmer Dabbelt <palmer@...osinc.com>
Subject: [ammarfaizi2-block:palmer/linux/for-next 3/3]
arch/riscv/mm/fault.c:126:9: error: 'pgd' undeclared; did you mean 'pid'?
tree: https://github.com/ammarfaizi2/linux-block palmer/linux/for-next
head: c4f1d47294c4a59c09d14c5802bc0e978bad7b9a
commit: c4f1d47294c4a59c09d14c5802bc0e978bad7b9a [3/3] riscv: mm: Remove the copy operation of pmd
config: riscv-randconfig-m031-20220222 (https://download.01.org/0day-ci/archive/20220223/202202230809.3HxMqsaH-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/c4f1d47294c4a59c09d14c5802bc0e978bad7b9a
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block palmer/linux/for-next
git checkout c4f1d47294c4a59c09d14c5802bc0e978bad7b9a
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/mm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
arch/riscv/mm/fault.c: In function 'vmalloc_fault':
>> arch/riscv/mm/fault.c:126:9: error: 'pgd' undeclared (first use in this function); did you mean 'pid'?
126 | pgd = (pgd_t *)pfn_to_virt(pfn) + index;
| ^~~
| pid
arch/riscv/mm/fault.c:126:9: note: each undeclared identifier is reported only once for each function it appears in
vim +126 arch/riscv/mm/fault.c
a51271d99cdd049 Pekka Enberg 2020-08-25 101
2baa6d9506f24d5 Pekka Enberg 2020-09-05 102 static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
ac416a724f11320 Pekka Enberg 2020-08-25 103 {
c4f1d47294c4a59 hanchuanhua 2022-01-27 104 pgd_t *pgd_k;
c4f1d47294c4a59 hanchuanhua 2022-01-27 105 pud_t *pud_k;
c4f1d47294c4a59 hanchuanhua 2022-01-27 106 p4d_t *p4d_k;
c4f1d47294c4a59 hanchuanhua 2022-01-27 107 pmd_t *pmd_k;
ac416a724f11320 Pekka Enberg 2020-08-25 108 pte_t *pte_k;
ac416a724f11320 Pekka Enberg 2020-08-25 109 int index;
bcacf5f6f239a9e Liu Shaohua 2020-10-26 110 unsigned long pfn;
ac416a724f11320 Pekka Enberg 2020-08-25 111
ac416a724f11320 Pekka Enberg 2020-08-25 112 /* User mode accesses just cause a SIGSEGV */
ac416a724f11320 Pekka Enberg 2020-08-25 113 if (user_mode(regs))
ac416a724f11320 Pekka Enberg 2020-08-25 114 return do_trap(regs, SIGSEGV, code, addr);
ac416a724f11320 Pekka Enberg 2020-08-25 115
ac416a724f11320 Pekka Enberg 2020-08-25 116 /*
ac416a724f11320 Pekka Enberg 2020-08-25 117 * Synchronize this task's top level page-table
ac416a724f11320 Pekka Enberg 2020-08-25 118 * with the 'reference' page table.
ac416a724f11320 Pekka Enberg 2020-08-25 119 *
ac416a724f11320 Pekka Enberg 2020-08-25 120 * Do _not_ use "tsk->active_mm->pgd" here.
ac416a724f11320 Pekka Enberg 2020-08-25 121 * We might be inside an interrupt in the middle
ac416a724f11320 Pekka Enberg 2020-08-25 122 * of a task switch.
ac416a724f11320 Pekka Enberg 2020-08-25 123 */
ac416a724f11320 Pekka Enberg 2020-08-25 124 index = pgd_index(addr);
bcacf5f6f239a9e Liu Shaohua 2020-10-26 125 pfn = csr_read(CSR_SATP) & SATP_PPN;
bcacf5f6f239a9e Liu Shaohua 2020-10-26 @126 pgd = (pgd_t *)pfn_to_virt(pfn) + index;
ac416a724f11320 Pekka Enberg 2020-08-25 127 pgd_k = init_mm.pgd + index;
ac416a724f11320 Pekka Enberg 2020-08-25 128
ac416a724f11320 Pekka Enberg 2020-08-25 129 if (!pgd_present(*pgd_k)) {
ac416a724f11320 Pekka Enberg 2020-08-25 130 no_context(regs, addr);
ac416a724f11320 Pekka Enberg 2020-08-25 131 return;
ac416a724f11320 Pekka Enberg 2020-08-25 132 }
ac416a724f11320 Pekka Enberg 2020-08-25 133 set_pgd(pgd, *pgd_k);
ac416a724f11320 Pekka Enberg 2020-08-25 134
ac416a724f11320 Pekka Enberg 2020-08-25 135 p4d_k = p4d_offset(pgd_k, addr);
ac416a724f11320 Pekka Enberg 2020-08-25 136 if (!p4d_present(*p4d_k)) {
ac416a724f11320 Pekka Enberg 2020-08-25 137 no_context(regs, addr);
ac416a724f11320 Pekka Enberg 2020-08-25 138 return;
ac416a724f11320 Pekka Enberg 2020-08-25 139 }
ac416a724f11320 Pekka Enberg 2020-08-25 140
ac416a724f11320 Pekka Enberg 2020-08-25 141 pud_k = pud_offset(p4d_k, addr);
ac416a724f11320 Pekka Enberg 2020-08-25 142 if (!pud_present(*pud_k)) {
ac416a724f11320 Pekka Enberg 2020-08-25 143 no_context(regs, addr);
ac416a724f11320 Pekka Enberg 2020-08-25 144 return;
ac416a724f11320 Pekka Enberg 2020-08-25 145 }
ac416a724f11320 Pekka Enberg 2020-08-25 146
ac416a724f11320 Pekka Enberg 2020-08-25 147 /*
ac416a724f11320 Pekka Enberg 2020-08-25 148 * Since the vmalloc area is global, it is unnecessary
ac416a724f11320 Pekka Enberg 2020-08-25 149 * to copy individual PTEs
ac416a724f11320 Pekka Enberg 2020-08-25 150 */
ac416a724f11320 Pekka Enberg 2020-08-25 151 pmd_k = pmd_offset(pud_k, addr);
ac416a724f11320 Pekka Enberg 2020-08-25 152 if (!pmd_present(*pmd_k)) {
ac416a724f11320 Pekka Enberg 2020-08-25 153 no_context(regs, addr);
ac416a724f11320 Pekka Enberg 2020-08-25 154 return;
ac416a724f11320 Pekka Enberg 2020-08-25 155 }
ac416a724f11320 Pekka Enberg 2020-08-25 156
ac416a724f11320 Pekka Enberg 2020-08-25 157 /*
ac416a724f11320 Pekka Enberg 2020-08-25 158 * Make sure the actual PTE exists as well to
ac416a724f11320 Pekka Enberg 2020-08-25 159 * catch kernel vmalloc-area accesses to non-mapped
ac416a724f11320 Pekka Enberg 2020-08-25 160 * addresses. If we don't do this, this will just
ac416a724f11320 Pekka Enberg 2020-08-25 161 * silently loop forever.
ac416a724f11320 Pekka Enberg 2020-08-25 162 */
ac416a724f11320 Pekka Enberg 2020-08-25 163 pte_k = pte_offset_kernel(pmd_k, addr);
ac416a724f11320 Pekka Enberg 2020-08-25 164 if (!pte_present(*pte_k)) {
ac416a724f11320 Pekka Enberg 2020-08-25 165 no_context(regs, addr);
ac416a724f11320 Pekka Enberg 2020-08-25 166 return;
ac416a724f11320 Pekka Enberg 2020-08-25 167 }
ac416a724f11320 Pekka Enberg 2020-08-25 168
ac416a724f11320 Pekka Enberg 2020-08-25 169 /*
ac416a724f11320 Pekka Enberg 2020-08-25 170 * The kernel assumes that TLBs don't cache invalid
ac416a724f11320 Pekka Enberg 2020-08-25 171 * entries, but in RISC-V, SFENCE.VMA specifies an
ac416a724f11320 Pekka Enberg 2020-08-25 172 * ordering constraint, not a cache flush; it is
ac416a724f11320 Pekka Enberg 2020-08-25 173 * necessary even after writing invalid entries.
ac416a724f11320 Pekka Enberg 2020-08-25 174 */
ac416a724f11320 Pekka Enberg 2020-08-25 175 local_flush_tlb_page(addr);
ac416a724f11320 Pekka Enberg 2020-08-25 176 }
ac416a724f11320 Pekka Enberg 2020-08-25 177
:::::: The code at line 126 was first introduced by commit
:::::: bcacf5f6f239a9e60287680514f392748cb4ec39 riscv: fix pfn_to_virt err in do_page_fault().
:::::: TO: Liu Shaohua <liush@...winnertech.com>
:::::: CC: Palmer Dabbelt <palmerdabbelt@...gle.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists