linux-kernel - Re: [PATCH bpf-next] bpf: add config to allow loading modules with BTF mismatches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <EE57D385-9144-407E-8DC5-0DFF76CC2200@fb.com>
Date:   Wed, 23 Feb 2022 05:08:53 +0000
From:   Song Liu <songliubraving@...com>
To:     Shung-Hsi Yu <shung-hsi.yu@...e.com>
CC:     Connor O'Brien <connoro@...gle.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, Martin Lau <kafai@...com>,
        Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Michal Suchánek <msuchanek@...e.de>
Subject: Re: [PATCH bpf-next] bpf: add config to allow loading modules with
 BTF mismatches



> On Feb 22, 2022, at 8:34 PM, Shung-Hsi Yu <shung-hsi.yu@...e.com> wrote:
> 
> On Wed, Feb 23, 2022 at 01:28:14AM +0000, Connor O'Brien wrote:
>> BTF mismatch can occur for a separately-built module even when the ABI
>> is otherwise compatible and nothing else would prevent successfully
>> loading. Add a new config to control how mismatches are handled. By
>> default, preserve the current behavior of refusing to load the
>> module. If MODULE_ALLOW_BTF_MISMATCH is enabled, load the module but
>> ignore its BTF information.
>> 
>> Suggested-by: Yonghong Song <yhs@...com>
>> Suggested-by: Michal Suchánek <msuchanek@...e.de>
>> Signed-off-by: Connor O'Brien <connoro@...gle.com>
> 
> Maybe reference the discussion thread as well?
> 
> Link: https://lore.kernel.org/bpf/CAADnVQJ+OVPnBz8z3vNu8gKXX42jCUqfuvhWAyCQDu8N_yqqwQ@mail.gmail.com/
> 
> Otherwise
> 
> Acked-by: Shung-Hsi Yu <shung-hsi.yu@...e.com>

Acked-by: Song Liu <songliubraving@...com>