[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220223055006.zlcwco7oducggxjw@vireshk-i7>
Date: Wed, 23 Feb 2022 11:20:06 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Lukasz Luba <lukasz.luba@....com>
Cc: linux-kernel@...r.kernel.org, dietmar.eggemann@....com,
rafael@...nel.org, daniel.lezcano@...aro.org, nm@...com,
sboyd@...nel.org, mka@...omium.org, dianders@...omium.org,
robh+dt@...nel.org, devicetree@...r.kernel.org,
linux-pm@...r.kernel.org
Subject: Re: [[PATCH v2 1/2] dt-bindings: opp: Add 'opp-microwatt' entry in
the OPP
On 22-02-22, 14:07, Lukasz Luba wrote:
> Add new entry for the OPP which provides information about power
> expressed in micro-Watts. It is useful for the Energy Model framework.
>
> Signed-off-by: Lukasz Luba <lukasz.luba@....com>
> ---
> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> index 15a76bcd6d42..3f07a279ed2a 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> @@ -93,6 +93,13 @@ patternProperties:
> minItems: 1
> maxItems: 8 # Should be enough regulators
>
> + opp-microwatt:
> + description:
> + Power for the OPP
> +
> + A value representing power for the OPP in micro-Watts.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
I was expecting a much larger change here. Look at how opp-microvolt and
opp-microamp is defined in this file.
Should this value be made per-supply/regulator, just like voltage/current ?
> opp-level:
> description:
> A value representing the performance level of the device.
--
viresh
Powered by blists - more mailing lists