[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DM4PR12MB5769CB86A0348A669647D0F3C33C9@DM4PR12MB5769.namprd12.prod.outlook.com>
Date: Wed, 23 Feb 2022 06:34:44 +0000
From: Krishna Yarlagadda <kyarlagadda@...dia.com>
To: Mark Brown <broonie@...nel.org>
CC: "thierry.reding@...il.com" <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
Sowjanya Komatineni <skomatineni@...dia.com>,
Laxman Dewangan <ldewangan@...dia.com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>
Subject: RE: [PATCH v2 5/5] spi: tegra210-quad: combined sequence mode
> -----Original Message-----
> From: Mark Brown <broonie@...nel.org>
> Sent: 23 February 2022 00:12
> To: Krishna Yarlagadda <kyarlagadda@...dia.com>
> Cc: thierry.reding@...il.com; Jonathan Hunter
> <jonathanh@...dia.com>; linux-spi@...r.kernel.org; linux-
> tegra@...r.kernel.org; Sowjanya Komatineni
> <skomatineni@...dia.com>; Laxman Dewangan
> <ldewangan@...dia.com>; robh+dt@...nel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> p.zabel@...gutronix.de
> Subject: Re: [PATCH v2 5/5] spi: tegra210-quad: combined sequence
> mode
>
> On Tue, Feb 22, 2022 at 11:26:11PM +0530, Krishna Yarlagadda wrote:
>
> > + val = tegra_qspi_readl(tqspi, QSPI_GLOBAL_CONFIG);
> > + val |= QSPI_CMB_SEQ_EN;
> > + tegra_qspi_writel(tqspi, val, QSPI_GLOBAL_CONFIG);
>
> I notice that nothing seems to clear QSPI_CMB_SEQ_EN - is that self
> clearing or something?
Need a change in non-combined sequence code to reset this.
Will add the change in v3
Powered by blists - more mailing lists