linux-kernel - Re: [PATCH] vt_ioctl: fix potential spectre v1 in VT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 23 Feb 2022 14:47:34 +0800
From:   Xiaomeng Tong <xiam0nd.tong@...il.com>
To:     jirislaby@...nel.org
Cc:     xiam0nd.tong@...il.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vt_ioctl: fix potential spectre v1 in VT_DISALLOCATE

On Tue, 22 Feb 2022 07:56:13 +0100, Jiri Slaby wrote:
> Could you add a break; here and remove the else branching completely?
> ...
> You could simply do:
>   arg = array_index_nospec(arg - 1, MAX_NR_CONSOLES);
> and remove
>    --arg;
> completely.

Already adjusted as suggested in Patch v2, thanks!

Best regards,
--
Xiaomeng Tong