[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220223070223.26845-1-hbh25y@gmail.com>
Date: Wed, 23 Feb 2022 15:02:23 +0800
From: Hangyu Hua <hbh25y@...il.com>
To: christophe.leroy@...roup.eu, mpe@...erman.id.au,
benh@...nel.crashing.org, paulus@...ba.org, peng.hao2@....com.cn,
wen.yang99@....com.cn
Cc: linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
Hangyu Hua <hbh25y@...il.com>
Subject: [PATCH] powerpc: 8xx: fix a return value error in mpc8xx_pic_init
mpc8xx_pic_init() should return -ENOMEM instead of 0 when
irq_domain_add_linear() return NULL. This cause mpc8xx_pics_init to continue
executing even if mpc8xx_pic_host is NULL.
Fixes: cc76404feaed ("powerpc/8xx: Fix possible device node reference leak")
Signed-off-by: Hangyu Hua <hbh25y@...il.com>
---
arch/powerpc/platforms/8xx/pic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/8xx/pic.c b/arch/powerpc/platforms/8xx/pic.c
index f2ba837249d6..04a6abf14c29 100644
--- a/arch/powerpc/platforms/8xx/pic.c
+++ b/arch/powerpc/platforms/8xx/pic.c
@@ -153,6 +153,7 @@ int __init mpc8xx_pic_init(void)
if (mpc8xx_pic_host == NULL) {
printk(KERN_ERR "MPC8xx PIC: failed to allocate irq host!\n");
ret = -ENOMEM;
+ goto out;
}
ret = 0;
--
2.25.1
Powered by blists - more mailing lists