linux-kernel - Re: [PATCH v7 05/11] dt-bindings: pwm: add microchip corepwm binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65edc257-82ec-e100-7a44-5c510aba51ce@canonical.com>
Date:   Wed, 23 Feb 2022 08:12:49 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        conor.dooley@...rochip.com
Cc:     linus.walleij@...aro.org, brgl@...ev.pl, robh+dt@...nel.org,
        jassisinghbrar@...il.com, thierry.reding@...il.com,
        lee.jones@...aro.org, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, paul.walmsley@...ive.com,
        palmer@...belt.com, aou@...s.berkeley.edu, geert@...ux-m68k.org,
        linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pwm@...r.kernel.org,
        linux-rtc@...r.kernel.org, linux-riscv@...ts.infradead.org,
        lewis.hanly@...rochip.com, daire.mcnamara@...rochip.com,
        ivan.griffin@...rochip.com, atishp@...osinc.com,
        Rob Herring <robh@...nel.org>,
        Palmer Dabbelt <palmer@...osinc.com>
Subject: Re: [PATCH v7 05/11] dt-bindings: pwm: add microchip corepwm binding

On 23/02/2022 07:20, Uwe Kleine-König wrote:
> On Mon, Feb 14, 2022 at 01:58:35PM +0000, conor.dooley@...rochip.com wrote:
>> From: Conor Dooley <conor.dooley@...rochip.com>
>>
>> Add device tree bindings for the Microchip fpga fabric based "core" PWM
>> controller.
>>
>> Reviewed-by: Rob Herring <robh@...nel.org>
>> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
>> Acked-by: Palmer Dabbelt <palmer@...osinc.com>
> 
> I like it:
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> nitpick: Put your S-o-b last in the commit log. (This doesn't justify a
> resend IMHO)

It should be the opposite - the first. First author signs the patch,
then comes review and finally an ack. Putting SoB at then suggests that
tags were accumulated before sending patch, out of mailing list.


Best regards,
Krzysztof