linux-kernel - Re: [RFC 1/9] ext4: Remove unused enum EXT4_FC_COMMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220223093713.fw7c54xmllxrmmld@quack3.lan>
Date:   Wed, 23 Feb 2022 10:37:13 +0100
From:   Jan Kara <jack@...e.cz>
To:     Ritesh Harjani <riteshh@...ux.ibm.com>
Cc:     linux-ext4@...r.kernel.org,
        Harshad Shirwadkar <harshadshirwadkar@...il.com>,
        Theodore Ts'o <tytso@....edu>, Jan Kara <jack@...e.cz>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 1/9] ext4: Remove unused enum EXT4_FC_COMMIT_FAILED

On Wed 23-02-22 02:04:09, Ritesh Harjani wrote:
> Below commit removed all references of EXT4_FC_COMMIT_FAILED.
> commit 0915e464cb274 ("ext4: simplify updating of fast commit stats")
> 
> Just remove it since it is not used anymore.
> 
> Signed-off-by: Ritesh Harjani <riteshh@...ux.ibm.com>

Sure. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

									Honza

> ---
>  fs/ext4/fast_commit.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/fast_commit.h b/fs/ext4/fast_commit.h
> index 02afa52e8e41..80414dcba6e1 100644
> --- a/fs/ext4/fast_commit.h
> +++ b/fs/ext4/fast_commit.h
> @@ -93,7 +93,6 @@ enum {
>  	EXT4_FC_REASON_RENAME_DIR,
>  	EXT4_FC_REASON_FALLOC_RANGE,
>  	EXT4_FC_REASON_INODE_JOURNAL_DATA,
> -	EXT4_FC_COMMIT_FAILED,
>  	EXT4_FC_REASON_MAX
>  };
>  
> -- 
> 2.31.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR