linux-kernel - Re: [pdx86-platform-drivers-x86:review-hans 40/40] ERROR: modpost: "battery_hook_register" [drivers/platform/x86/lg-laptop.ko] undefined!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 23 Feb 2022 11:35:35 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     kernel test robot <lkp@...el.com>, Matan Ziv-Av <matan@...alib.org>
Cc:     kbuild-all@...ts.01.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [pdx86-platform-drivers-x86:review-hans 40/40] ERROR: modpost:
 "battery_hook_register" [drivers/platform/x86/lg-laptop.ko] undefined!

Hi,

On 2/23/22 09:44, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
> head:   7e45710a8a56896d7af5c5ff4ed7cfb18573791b
> commit: 7e45710a8a56896d7af5c5ff4ed7cfb18573791b [40/40] lg-laptop: Move setting of battery charge limit to common location
> config: x86_64-randconfig-r035-20220221 (https://download.01.org/0day-ci/archive/20220223/202202231609.ZQpgFUIn-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build):
>         # https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=7e45710a8a56896d7af5c5ff4ed7cfb18573791b
>         git remote add pdx86-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
>         git fetch --no-tags pdx86-platform-drivers-x86 review-hans
>         git checkout 7e45710a8a56896d7af5c5ff4ed7cfb18573791b
>         # save the config file to linux build tree
>         mkdir build_dir
>         make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>, old ones prefixed by <<):
> 
>>> ERROR: modpost: "battery_hook_register" [drivers/platform/x86/lg-laptop.ko] undefined!
>>> ERROR: modpost: "battery_hook_unregister" [drivers/platform/x86/lg-laptop.ko] undefined!

Ah yes, config LG_LAPTOP needs a depends on ACPI_BATTERY now.

I've squashed a fix for this into the original commit in my review-hans branch.

Regards,

Hans