linux-kernel - Re: [PATCH v4 01/32] mtd: spi-nor: atmel: unify function names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220223113303.4cashhkp624yo5sg@ti.com>
Date:   Wed, 23 Feb 2022 17:03:03 +0530
From:   Pratyush Yadav <p.yadav@...com>
To:     Michael Walle <michael@...le.cc>
CC:     <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        <yaliang.wang@...driver.com>
Subject: Re: [PATCH v4 01/32] mtd: spi-nor: atmel: unify function names

On 22/02/22 08:26AM, Michael Walle wrote:
> Am 2022-02-22 08:23, schrieb Pratyush Yadav:
> > On 21/02/22 01:07PM, Michael Walle wrote:
> > > To avoid name clashes unify all the function and static object names
> > > and
> > > use one of the following prefixes which should be sufficiently unique:
> > >  - <vendor>_nor_
> > >  - <flash_family>_nor_
> > >  - <flash_part>_
> > 
> > Shouldn't this be "<flash_part>_nor_"?
> 
> No, a part name is already unique and its the same "style" as spi nand
> is doing it.

Okay. Fine by me.

I have not went and checked every single function changed. I trust you 
to get them right.

Acked-by: Pratyush Yadav <p.yadav@...com>

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.