linux-kernel - Re: [PATCH 3/3] KVM: SVM: fix race between interrupt delivery and AVIC inhibition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e07aedc927a03bc921980430303864f34c34621e.camel@redhat.com>
Date:   Wed, 23 Feb 2022 14:15:45 +0200
From:   Maxim Levitsky <mlevitsk@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH 3/3] KVM: SVM: fix race between interrupt delivery and
 AVIC inhibition

On Fri, 2022-02-11 at 17:35 +0000, Sean Christopherson wrote:
> On Fri, Feb 11, 2022, Paolo Bonzini wrote:
> > On 2/11/22 18:11, Sean Christopherson wrote:
> > > > +		/* Process the interrupt with a vmexit.  */
> > > 
> > > Double spaces at the end.  But I would prefer we omit the comment entirely,
> > > there is no guarantee the vCPU is in the guest or even running.
> > 
> > Sure, or perhaps "process the interrupt in inject_pending_event".
> 
> s/in/via?
> 
> > Regarding the two spaces, it used to a pretty strict rule in the US with
> > typewriters.  It helps readability of monospaced fonts
> > (https://www.cultofpedagogy.com/two-spaces-after-period/), and code is
> > mostly monospaced...  But well, the title of the article says it all.
> 
> Preaching to the choir, I'm a firm believer that there should always be two spaces
> after a full stop, monospace or not.  Unless it's the end of a comment. :-D
> 
As someone who gotten into typewritter repair hobby lately, I sure understand what you mean.
But for some reason I still use one space after period even on a typewritter and
that doesn't bother me :-)

Best regards,
	Maxim Levitsky