linux-kernel - Re: [PATCH printk v1 12/13] printk: remove @console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YhYlz8l0jZVeUXrq@alley>
Date:   Wed, 23 Feb 2022 13:17:19 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     John Ogness <john.ogness@...utronix.de>
Cc:     Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH printk v1 12/13] printk: remove @console_locked

On Mon 2022-02-07 20:49:22, John Ogness wrote:
> The static global variable @console_locked is used to help debug VT
> code to make sure that certain code paths are running with the
> console_lock held. However, this information is also available with
> the static global variable @consoles_paused (for locking via
> console_lock()), and the static global variable @console_lock_count
> (for locking via console_trylock()).
> 
> Remove @console_locked and update is_console_locked() to use the
> alternative variables.

It is great that we are also removing something ;-)

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr