linux-kernel - Re: [kvalo-ath:pending 37/42] drivers/net/wireless/ath/ath11k/wow.c:467:5: error: redefinition of 'ath11k_wow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zgmgtfie.fsf@kernel.org>
Date:   Thu, 24 Feb 2022 18:07:21 +0200
From:   Kalle Valo <kvalo@...nel.org>
To:     kernel test robot <lkp@...el.com>
Cc:     Carl Huang <quic_cjhuang@...cinc.com>, kbuild-all@...ts.01.org,
        ath10k@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Baochen Qiang <quic_bqiang@...cinc.com>,
        Wen Gong <quic_wgong@...cinc.com>, ath11k@...ts.infradead.org
Subject: Re: [kvalo-ath:pending 37/42] drivers/net/wireless/ath/ath11k/wow.c:467:5: error: redefinition of 'ath11k_wow_init'

+ ath11k

kernel test robot <lkp@...el.com> writes:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending
> head:   4136ddcfda28450e2d01173e37300b95c8687d9b
> commit: cae84a492cacd9b4eecaafd5dab33f5beba8806e [37/42] ath11k: Add basic WoW functionalities
> config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220223/202202230812.uOGgSw5k-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id=cae84a492cacd9b4eecaafd5dab33f5beba8806e
>         git remote add kvalo-ath https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
>         git fetch --no-tags kvalo-ath pending
>         git checkout cae84a492cacd9b4eecaafd5dab33f5beba8806e
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
>
> All errors (new ones prefixed by >>):
>
>    drivers/net/wireless/ath/ath11k/wow.c:357:5: warning: no previous prototype for 'ath11k_wow_op_suspend' [-Wmissing-prototypes]
>      357 | int ath11k_wow_op_suspend(struct ieee80211_hw *hw,
>          |     ^~~~~~~~~~~~~~~~~~~~~
>    drivers/net/wireless/ath/ath11k/wow.c:416:6: warning: no previous
> prototype for 'ath11k_wow_op_set_wakeup' [-Wmissing-prototypes]
>      416 | void ath11k_wow_op_set_wakeup(struct ieee80211_hw *hw, bool enabled)
>          |      ^~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/net/wireless/ath/ath11k/wow.c:425:5: warning: no previous
> prototype for 'ath11k_wow_op_resume' [-Wmissing-prototypes]
>      425 | int ath11k_wow_op_resume(struct ieee80211_hw *hw)
>          |     ^~~~~~~~~~~~~~~~~~~~
>>> drivers/net/wireless/ath/ath11k/wow.c:467:5: error: redefinition of
>>> 'ath11k_wow_init'
>      467 | int ath11k_wow_init(struct ath11k *ar)
>          |     ^~~~~~~~~~~~~~~
>    In file included from drivers/net/wireless/ath/ath11k/core.h:26,
>                     from drivers/net/wireless/ath/ath11k/wow.c:11:
>    drivers/net/wireless/ath/ath11k/wow.h:40:19: note: previous definition of 'ath11k_wow_init' with type 'int(struct ath11k *)'
>       40 | static inline int ath11k_wow_init(struct ath11k *ar)
>          |                   ^~~~~~~~~~~~~~~
>    drivers/net/wireless/ath/ath11k/wow.c: In function 'ath11k_wow_init':
>>> drivers/net/wireless/ath/ath11k/wow.c:482:22: error: 'struct wiphy'
>>> has no member named 'wowlan'
>      482 |         ar->hw->wiphy->wowlan = &ar->wow.wowlan_support;
>          |                      ^~

I was able to reproduce the errors by disabling CONFIG_PM. I fixed them
and pushed the new patch to the pending branch:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=624c999c214f02004c2f996aa6ce3a17dfbebd18

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches