linux-kernel - Re: [RFC V5 10/16] blk-wbt: get rid of wbt_enable/disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yhe4xA7r6Mew5tXE@slm.duckdns.org>
Date:   Thu, 24 Feb 2022 06:56:36 -1000
From:   Tejun Heo <tj@...nel.org>
To:     "Wang Jianchao (Kuaishou)" <jianchao.wan9@...il.com>
Cc:     Jens Axboe <axboe@...nel.dk>, Josef Bacik <jbacik@...com>,
        Bart Van Assche <bvanassche@....org>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC V5 10/16] blk-wbt: get rid of wbt_enable/disable_default()

On Thu, Feb 24, 2022 at 05:06:48PM +0800, Wang Jianchao (Kuaishou) wrote:
> wbt_enable_default() is used to open wbt feature by default.
> wbt_disable_default() is only employed by bfq which has similar
> writeback throttling mechanism. This kind of policy should be
> selected by the user instead of being set in kernel. This patch
> get rid of the interfaces and let the user configure appropricate
> blk-rq-qos policy by themselves.

Some combinations simply don't work well together. The kernel should be able
to provide a reasonble default behavior.

Nacked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun