linux-kernel - Re: [PATCH v5 2/9] dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yhe95rXZc7RzgO5o@robh.at.kernel.org>
Date:   Thu, 24 Feb 2022 11:18:30 -0600
From:   Rob Herring <robh@...nel.org>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Benoît Cousson <bcousson@...libre.com>,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Nicolas Saenz Julienne <nsaenz@...nel.org>,
        Ray Jui <rjui@...adcom.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Scott Branden <sbranden@...adcom.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Tony Lindgren <tony@...mide.com>, kernel@...gutronix.de,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH v5 2/9] dt-bindings: net: add schema for Microchip/SMSC
 LAN95xx USB Ethernet controllers

On Wed, Feb 16, 2022 at 08:49:20AM +0100, Oleksij Rempel wrote:
> Create initial schema for Microchip/SMSC LAN95xx USB Ethernet controllers and
> import some of currently supported USB IDs form drivers/net/usb/smsc95xx.c
> 
> These devices are already used in some of DTs. So, this schema makes it official.
> NOTE: there was no previously documented txt based DT binding for this
> controllers.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
>  .../bindings/net/microchip,lan95xx.yaml       | 80 +++++++++++++++++++
>  1 file changed, 80 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> new file mode 100644
> index 000000000000..8521c65366b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/microchip,lan95xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: The device tree bindings for the USB Ethernet controllers
> +
> +maintainers:
> +  - Oleksij Rempel <o.rempel@...gutronix.de>
> +
> +description: |
> +  Device tree properties for hard wired SMSC95xx compatible USB Ethernet
> +  controller.
> +
> +allOf:
> +  - $ref: ethernet-controller.yaml#
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - usb424,9500   # SMSC9500 USB Ethernet Device
> +          - usb424,9505   # SMSC9505 USB Ethernet Device
> +          - usb424,9530   # SMSC LAN9530 USB Ethernet Device
> +          - usb424,9730   # SMSC LAN9730 USB Ethernet Device
> +          - usb424,9900   # SMSC9500 USB Ethernet Device (SAL10)
> +          - usb424,9901   # SMSC9505 USB Ethernet Device (SAL10)
> +          - usb424,9902   # SMSC9500A USB Ethernet Device (SAL10)
> +          - usb424,9903   # SMSC9505A USB Ethernet Device (SAL10)
> +          - usb424,9904   # SMSC9512/9514 USB Hub & Ethernet Device (SAL10)
> +          - usb424,9905   # SMSC9500A USB Ethernet Device (HAL)
> +          - usb424,9906   # SMSC9505A USB Ethernet Device (HAL)
> +          - usb424,9907   # SMSC9500 USB Ethernet Device (Alternate ID)
> +          - usb424,9908   # SMSC9500A USB Ethernet Device (Alternate ID)
> +          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Devic.  ID)
> +          - usb424,9e00   # SMSC9500A USB Ethernet Device
> +          - usb424,9e01   # SMSC9505A USB Ethernet Device
> +          - usb424,9e08   # SMSC LAN89530 USB Ethernet Device
> +          - usb424,ec00   # SMSC9512/9514 USB Hub & Ethernet Device
> +
> +  reg: true
> +  local-mac-address: true
> +  mac-address: true
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    usb {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ethernet@1 {
> +            compatible = "usb424,ec00";

If this is a hub/ethernet combo device, how is it valid to be standalone 
without the hub?

> +            reg = <1>;
> +            local-mac-address = [00 00 00 00 00 00];
> +        };
> +    };
> +  - |
> +    usb {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        usb1@1 {
> +            compatible = "usb424,9514";

Not documented.

> +            reg = <1>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            ethernet@1 {
> +               compatible = "usb424,ec00";
> +               reg = <1>;
> +            };
> +        };
> +    };
> -- 
> 2.30.2
> 
>