linux-kernel - Re: [PATCH] ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04e79b9c-ccb1-119a-c2e2-34c8ca336215@linux.intel.com>
Date:   Thu, 24 Feb 2022 12:05:30 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Ammar Faizi <ammarfaizi2@...weeb.org>,
        Mark Brown <broonie@...nel.org>
Cc:     alsa-devel@...a-project.org,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Rander Wang <rander.wang@...el.com>,
        linux-kernel@...r.kernel.org, Takashi Iwai <tiwai@...e.com>,
        Keyon Jie <yang.jie@...ux.intel.com>, stable@...r.kernel.org,
        Liam Girdwood <lgirdwood@...il.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Daniel Baluta <daniel.baluta@....com>,
        sound-open-firmware@...a-project.org
Subject: Re: [PATCH] ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM


>> From: Ammar Faizi <ammarfaizi2@...weeb.org>
>>
>> Do not call snd_dma_free_pages() when snd_dma_alloc_pages() returns
>> -ENOMEM because it leads to a NULL pointer dereference bug.
> 
> Reviewed-by: Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>

Thanks for this patch. looks good and tested by our CI, so

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>