linux-kernel - [jirislaby:devel 1/29] drivers/tty/serial/sunsab.c:869:45: error: passing argument 4 of 'uart_console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 25 Feb 2022 03:09:57 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [jirislaby:devel 1/29] drivers/tty/serial/sunsab.c:869:45: error:
 passing argument 4 of 'uart_console_write' from incompatible pointer type

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git devel
head:   89830a2e427ed8ad318c6183ad524709ba507133
commit: 2f078dc9af6a2039313d845c99f8f16c36229608 [1/29] serial: make uart_console_write->putchar()'s character an unsigned char
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20220225/202202250136.ZumlUcBa-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git/commit/?id=2f078dc9af6a2039313d845c99f8f16c36229608
        git remote add jirislaby https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git
        git fetch --no-tags jirislaby devel
        git checkout 2f078dc9af6a2039313d845c99f8f16c36229608
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/tty/serial/sunsab.c: In function 'sunsab_console_write':
>> drivers/tty/serial/sunsab.c:869:45: error: passing argument 4 of 'uart_console_write' from incompatible pointer type [-Werror=incompatible-pointer-types]
     869 |         uart_console_write(&up->port, s, n, sunsab_console_putchar);
         |                                             ^~~~~~~~~~~~~~~~~~~~~~
         |                                             |
         |                                             void (*)(struct uart_port *, int)
   In file included from drivers/tty/serial/sunsab.c:43:
   include/linux/serial_core.h:402:32: note: expected 'void (*)(struct uart_port *, unsigned char)' but argument is of type 'void (*)(struct uart_port *, int)'
     402 |                         void (*putchar)(struct uart_port *, unsigned char));
         |                         ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for OMAP_GPMC
   Depends on MEMORY && OF_ADDRESS
   Selected by
   - MTD_NAND_OMAP2 && MTD && MTD_RAW_NAND && (ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST && HAS_IOMEM


vim +/uart_console_write +869 drivers/tty/serial/sunsab.c

^1da177e4c3f41 drivers/serial/sunsab.c     Linus Torvalds  2005-04-16  857  
^1da177e4c3f41 drivers/serial/sunsab.c     Linus Torvalds  2005-04-16  858  static void sunsab_console_write(struct console *con, const char *s, unsigned n)
^1da177e4c3f41 drivers/serial/sunsab.c     Linus Torvalds  2005-04-16  859  {
^1da177e4c3f41 drivers/serial/sunsab.c     Linus Torvalds  2005-04-16  860  	struct uart_sunsab_port *up = &sunsab_ports[con->index];
f3c681c028846b drivers/serial/sunsab.c     David S. Miller 2007-07-15  861  	unsigned long flags;
f3c681c028846b drivers/serial/sunsab.c     David S. Miller 2007-07-15  862  	int locked = 1;
f3c681c028846b drivers/serial/sunsab.c     David S. Miller 2007-07-15  863  
e58e241c178885 drivers/tty/serial/sunsab.c David Miller    2014-03-04  864  	if (up->port.sysrq || oops_in_progress)
e58e241c178885 drivers/tty/serial/sunsab.c David Miller    2014-03-04  865  		locked = spin_trylock_irqsave(&up->port.lock, flags);
e58e241c178885 drivers/tty/serial/sunsab.c David Miller    2014-03-04  866  	else
e58e241c178885 drivers/tty/serial/sunsab.c David Miller    2014-03-04  867  		spin_lock_irqsave(&up->port.lock, flags);
^1da177e4c3f41 drivers/serial/sunsab.c     Linus Torvalds  2005-04-16  868  
d358788f3f3011 drivers/serial/sunsab.c     Russell King    2006-03-20 @869  	uart_console_write(&up->port, s, n, sunsab_console_putchar);
^1da177e4c3f41 drivers/serial/sunsab.c     Linus Torvalds  2005-04-16  870  	sunsab_tec_wait(up);
f3c681c028846b drivers/serial/sunsab.c     David S. Miller 2007-07-15  871  
f3c681c028846b drivers/serial/sunsab.c     David S. Miller 2007-07-15  872  	if (locked)
e58e241c178885 drivers/tty/serial/sunsab.c David Miller    2014-03-04  873  		spin_unlock_irqrestore(&up->port.lock, flags);
^1da177e4c3f41 drivers/serial/sunsab.c     Linus Torvalds  2005-04-16  874  }
^1da177e4c3f41 drivers/serial/sunsab.c     Linus Torvalds  2005-04-16  875  

:::::: The code at line 869 was first introduced by commit
:::::: d358788f3f30113e49882187d794832905e42592 [SERIAL] kernel console should send CRLF not LFCR

:::::: TO: Russell King <rmk@...-67.arm.linux.org.uk>
:::::: CC: Russell King <rmk+kernel@....linux.org.uk>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org