[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YhfaSqWInwgsu30x@robh.at.kernel.org>
Date: Thu, 24 Feb 2022 13:19:38 -0600
From: Rob Herring <robh@...nel.org>
To: Rex-BC Chen <rex-bc.chen@...iatek.com>
Cc: chunkuang.hu@...nel.org, matthias.bgg@...il.com,
p.zabel@...gutronix.de, airlied@...ux.ie, daniel@...ll.ch,
jassisinghbrar@...il.com, fparent@...libre.com,
yongqiang.niu@...iatek.com, hsinyi@...omium.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org,
Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH v4,2/5] dt-bindings: display: mediatek: add MT8186 SoC
binding
On Tue, Feb 22, 2022 at 01:28:00PM +0800, Rex-BC Chen wrote:
> Add MT8186 SoC binding to AAL, CCORR, COLOR, DITHER, GAMMA, MUTEX,
> OVL, POSTMASK and RDMA.
>
> Signed-off-by: Rex-BC Chen <rex-bc.chen@...iatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 7 +++++++
> .../bindings/display/mediatek/mediatek,ccorr.yaml | 5 +++++
> .../bindings/display/mediatek/mediatek,color.yaml | 1 +
> .../bindings/display/mediatek/mediatek,dither.yaml | 1 +
> .../bindings/display/mediatek/mediatek,gamma.yaml | 1 +
> .../bindings/display/mediatek/mediatek,mutex.yaml | 2 ++
> .../bindings/display/mediatek/mediatek,ovl-2l.yaml | 5 +++++
> .../devicetree/bindings/display/mediatek/mediatek,ovl.yaml | 5 +++++
> .../bindings/display/mediatek/mediatek,postmask.yaml | 5 +++++
> .../bindings/display/mediatek/mediatek,rdma.yaml | 1 +
> 10 files changed, 33 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> index 225f9dd726d2..3a5416937293 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> @@ -23,6 +23,8 @@ properties:
> oneOf:
> - items:
> - const: mediatek,mt8173-disp-aal
> + - items:
> + - const: mediatek,mt8183-disp-aal
This patch is for 8186...
> - items:
> - enum:
> - mediatek,mt2712-disp-aal
> @@ -31,6 +33,11 @@ properties:
> - mediatek,mt8195-disp-aal
> - enum:
> - mediatek,mt8173-disp-aal
> + - items:
> + - enum:
> + - mediatek,mt8186-disp-aal
> + - enum:
> + - mediatek,mt8183-disp-aal
There won't be more than 1 fallback, so use const rather than enum.
>
> reg:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> index 6894b6999412..8ac87b5896ac 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> @@ -30,6 +30,11 @@ properties:
> - mediatek,mt8195-disp-ccorr
> - enum:
> - mediatek,mt8192-disp-ccorr
> + - items:
> + - enum:
> + - mediatek,mt8186-disp-ccorr
> + - enum:
> + - mediatek,mt8183-disp-ccorr
Same here.
>
> reg:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml
> index bc83155b3b4c..d0a4b9eb71fd 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml
> @@ -37,6 +37,7 @@ properties:
> - items:
> - enum:
> - mediatek,mt8183-disp-color
> + - mediatek,mt8186-disp-color
> - mediatek,mt8192-disp-color
> - mediatek,mt8195-disp-color
> - enum:
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml
> index 9d89297f5f1d..9a08514ed909 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml
> @@ -26,6 +26,7 @@ properties:
> - const: mediatek,mt8183-disp-dither
> - items:
> - enum:
> + - mediatek,mt8186-disp-dither
> - mediatek,mt8192-disp-dither
> - mediatek,mt8195-disp-dither
> - enum:
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> index 247baad147b3..6d96f6736d91 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> @@ -27,6 +27,7 @@ properties:
> - const: mediatek,mt8183-disp-gamma
> - items:
> - enum:
> + - mediatek,mt8186-disp-gamma
> - mediatek,mt8192-disp-gamma
> - mediatek,mt8195-disp-gamma
> - enum:
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.yaml
> index 6eca525eced0..55391b5c08c4 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.yaml
> @@ -34,6 +34,8 @@ properties:
> - const: mediatek,mt8173-disp-mutex
> - items:
> - const: mediatek,mt8183-disp-mutex
> + - items:
> + - const: mediatek,mt8186-disp-mutex
> - items:
> - const: mediatek,mt8192-disp-mutex
All these single entry cases can be a single enum.
> - items:
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml
> index 611a2dbdefa4..f7f89485a5ae 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml
> @@ -25,6 +25,11 @@ properties:
> - const: mediatek,mt8183-disp-ovl-2l
> - items:
> - const: mediatek,mt8192-disp-ovl-2l
> + - items:
> + - enum:
> + - mediatek,mt8186-disp-ovl-2l
> + - enum:
> + - mediatek,mt8192-disp-ovl-2l
>
> reg:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> index e71f79bc2dee..110e6b2747bc 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> @@ -40,6 +40,11 @@ properties:
> - mediatek,mt8195-disp-ovl
> - enum:
> - mediatek,mt8183-disp-ovl
> + - items:
> + - enum:
> + - mediatek,mt8186-disp-ovl
> + - enum:
> + - mediatek,mt8192-disp-ovl
>
> reg:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,postmask.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,postmask.yaml
> index 6ac1da2e8871..22c333d09465 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,postmask.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,postmask.yaml
> @@ -23,6 +23,11 @@ properties:
> oneOf:
> - items:
> - const: mediatek,mt8192-disp-postmask
> + - items:
> + - enum:
> + - mediatek,mt8186-disp-postmask
> + - enum:
> + - mediatek,mt8192-disp-postmask
>
> reg:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml
> index 8ef821641672..4f1c935cdf70 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml
> @@ -39,6 +39,7 @@ properties:
> - mediatek,mt2701-disp-rdma
> - items:
> - enum:
> + - mediatek,mt8186-disp-rdma
> - mediatek,mt8192-disp-rdma
> - enum:
> - mediatek,mt8183-disp-rdma
> --
> 2.18.0
>
>
Powered by blists - more mailing lists